script: Update placeholder-shown state during IME composition events#40082
Merged
jdm merged 2 commits intoservo:mainfrom Oct 23, 2025
Merged
script: Update placeholder-shown state during IME composition events#40082jdm merged 2 commits intoservo:mainfrom
jdm merged 2 commits intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
Member
|
@notJoon Thanks for the fix! Please make sure to sign you commit with |
mrobinson
approved these changes
Oct 22, 2025
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Lee ByeongJun <[email protected]>
notJoon
force-pushed
the
update-placeholder-shown-state
branch
from
6e544c4 to
260c827
Compare
servo-highfive
added
the
S-awaiting-review
Contributor
Author
|
@mrobinson Thank you for the review. I've added the sign to the commit message. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users input Unicode characters (such as Korean) in input fields, there was an issue where the placeholder text did not disappear and overlapped with the entered text. With regular alphabetic input, this placeholder disappears normally.
To fix this, adds
update_placeholder_shown_state()calls to the IME composition event handlers inHTMLInputElement, ensuring the placeholder is properly hidden when IME input begins and remains hidden during composition.Before fix
After fix
Testing: Manually tested on MacOS and confirmed the overlapping text issue no longer occurs