Implement pending preload responses with futures#40059
Implement pending preload responses with futures#40059TimvdLippe merged 12 commits intoservo:mainfrom
Conversation
TimvdLippe
left a comment
There was a problem hiding this comment.
@jdm I tried to follow your advice in #39794 (comment) I thought I had the gist of it, but then I ran into macro problems with cloning and serialization. Since this is the first time for me working with futures, I would like some guidance on how to proceed and where I should put what. Thanks in advance!
2e35df9 to
e926a72
Compare
|
🔨 Triggering try run (#20597890883) for Linux (WPT) |
d9ecbcd to
edadbf7
Compare
|
edadbf7 to
315d780
Compare
|
Test results for linux-wpt from try job (#20597890883): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (35)
Stable unexpected results (6)
|
|
|
315d780 to
ee234c1
Compare
|
🔨 Triggering try run (#20598548412) for Linux (WPT) |
|
Test results for linux-wpt from try job (#20598548412): Flaky unexpected result (37)
Stable unexpected results that are known to be intermittent (29)
Stable unexpected results (5)
|
|
|
ee234c1 to
6c1c918
Compare
6c1c918 to
5654a90
Compare
|
I'm concerned that the test results here keep switching. I was curious about the new I think we should spend more time looking into the test results before trying to merge this. |
|
I'm going to make a pull request to this branch that improves the test result situation. |
Part of servo#35035 Co-authored-by: Josh Matthews <[email protected]> Signed-off-by: Tim van der Lippe <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
…d events. Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Tim van der Lippe <[email protected]>
75609fb to
f5eb3ad
Compare
|
🔨 Triggering try run (#20691771704) for Linux (WPT) |
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56974). |
|
Test results for linux-wpt from try job (#20691771704): Flaky unexpected result (30)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (7)
|
|
|
Signed-off-by: Tim van der Lippe <[email protected]>
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56974). |
This implements waiting for pending preloads, where the preload request
is still fetching the result when the second "real" request is started. It is
implemented by storing responses in the
SharedPreloadedResourceswhich is communicated via
PreloadIdsend to theCoreResourceManager.Part of #35035