Skip to content

script: Support observing "device-pixel-content-box" with ResizeObserver#40056

Merged
simonwuelker merged 2 commits intoservo:mainfrom
simonwuelker:resize-observer-device-pixel
Oct 22, 2025
Merged

script: Support observing "device-pixel-content-box" with ResizeObserver#40056
simonwuelker merged 2 commits intoservo:mainfrom
simonwuelker:resize-observer-device-pixel

Conversation

@simonwuelker
Copy link
Copy Markdown
Contributor

Testing: New web platform tests start to pass
Part of #39790

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 21, 2025
Comment on lines +1 to +2
[devicepixel2.html]
expected: FAIL
Copy link
Copy Markdown
Contributor Author

@simonwuelker simonwuelker Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should not have passed previously. We fail it because we don't do subpixel snapping when calculating the device-pixel-content-box yet.

See https://searchfox.org/firefox-main/rev/8e5d58cfed616cb90586c614e53d8ab1ffc8af27/dom/base/ResizeObserver.cpp#123-127 for reference.

I'll file a follow up issue once this merges.

Copy link
Copy Markdown
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 21, 2025
Signed-off-by: Simon Wülker <[email protected]>
@simonwuelker simonwuelker force-pushed the resize-observer-device-pixel branch from 5863887 to 89a27b4 Compare October 22, 2025 00:14
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 22, 2025
@simonwuelker simonwuelker added this pull request to the merge queue Oct 22, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 22, 2025
Merged via the queue into servo:main with commit 024c46a Oct 22, 2025
33 checks passed
@simonwuelker simonwuelker deleted the resize-observer-device-pixel branch October 22, 2025 01:33
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants