compositor: Have viewport meta tag affect the layout viewport#40055
Merged
atbrakhi merged 1 commit intoservo:mainfrom Oct 21, 2025
Merged
compositor: Have viewport meta tag affect the layout viewport#40055atbrakhi merged 1 commit intoservo:mainfrom
atbrakhi merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
mrobinson
approved these changes
Oct 21, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-review
Member
|
Isn't it what I did here : #39067 ? @mrobinson cc: @xiaochengh |
Member
I left a comment asking you to reopen the PR if it was still an issue (as the original bug was closed), but didn't see any activity. We were reading the specifications and stumbled on this issue independently. We'll add you as a co-author here. |
The CSS specifications defines two viewports, the "layout viewport" and the visual viewport. The layout viewport affects layout and the visual viewport is the result of applying pinch zoom. This changes makes it so that the initial-scale property of <meta type="viewport"> affects the layout viewport. Co-authored-by: Shubham Gupta <[email protected]> Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: atbrakhi <[email protected]>
Member
Author
|
@shubhamg13 i have added you as co-author, sorry for the confusion. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSS specifications defines two viewports1, the "layout viewport" and the visual viewport. The layout viewport affects layout and the visual viewport is the result of applying pinch zoom. This changes makes it so that the initial-scale property of
<meta type="viewport">affects the layout viewport.Testing: Added a new unit test
Footnotes
https://www.w3.org/TR/css-viewport-1/#the-viewport ↩