layout: Simplify InlineFormattingContextBuilder::start_inline_box()#40037
Merged
Loirooriol merged 1 commit intoservo:mainfrom Oct 21, 2025
Merged
layout: Simplify InlineFormattingContextBuilder::start_inline_box()#40037Loirooriol merged 1 commit intoservo:mainfrom
InlineFormattingContextBuilder::start_inline_box()#40037Loirooriol merged 1 commit intoservo:mainfrom
Conversation
This patch removes the `block_in_inline_splits` parameter, since the single caller was just passing None. Then this parameter will only be provided for `start_inline_box_internal()`, which is made private since its an internal method as the name indicates. Signed-off-by: Oriol Brufau <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
approved these changes
Oct 21, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the
block_in_inline_splitsparameter, since the single caller was just passing None. Then this parameter will only be provided forstart_inline_box_internal(), which is made private since its an internal method as the name indicates.Testing: Not needed, no behavior change