script: Add CanGc to Seekable method in HtmlMediaElement#40033
Merged
jdm merged 3 commits intoservo:mainfrom Oct 21, 2025
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
jdm
changed the title
jdm
changed the title
jdm
requested changes
Oct 20, 2025
Member
jdm
left a comment
jdm
left a comment
There was a problem hiding this comment.
Thanks, this is great! This has a much bigger impact than I originally guessed.
servo-highfive
added
S-needs-code-changes
Taym95
reviewed
Oct 21, 2025
jdm
approved these changes
Oct 21, 2025
servo-highfive
removed
the
S-awaiting-review
willypuzzle
force-pushed
the
39944-HTMLMediaElement-Seekable-needs-a-CanGc-argument
branch
from
0acbbaa to
1ce4784
Compare
servo-highfive
added
the
S-awaiting-review
Contributor
Author
|
@jdm how can I correct the linting errors in the pipeline? |
Contributor
Rebasing is enough, it was fixed in a previous pr. |
Signed-off-by: Domenico Rizzo <[email protected]>
Signed-off-by: Domenico Rizzo <[email protected]>
Signed-off-by: Domenico Rizzo <[email protected]>
willypuzzle
force-pushed
the
39944-HTMLMediaElement-Seekable-needs-a-CanGc-argument
branch
from
1ce4784 to
b3499ac
Compare
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
willypuzzle
deleted the
39944-HTMLMediaElement-Seekable-needs-a-CanGc-argument
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored Seekable and Seek method in HtmlMediaElement, adding CanGC argument on all its calls.
Testing: No tests needed
Fixes: #39944