wdspec tests: Check correct node type instead of asserting error for script execution by yezhizhen · Pull Request #39988 · servo/servo

yezhizhen · 2025-10-19T14:19:22Z

These tests suggest that attribute nodes, document etc. are invalid node. That is simply not true based on spec.

Only Firefox pass these tests, while Chrome/Safari fails.
https://wpt.fyi/results/webdriver/tests/classic/execute_script?label=master

There is an ongoing discussion: w3c/webdriver#1687 (comment)

--
EDIT: Instead of removing these tests, we check

whether the node type returned is correct
whether the serialization for enumerable properties for fallback plain object is correct.

Signed-off-by: Euclid <[email protected]>

servo-wpt-sync · 2025-10-19T14:22:16Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#55534) with upstreamable changes.

Signed-off-by: Euclid <[email protected]>

jgraham · 2025-10-20T09:16:29Z

The WebDriver spec seems very clear here, in the serializer we explicitly switch on whether the input object is an Element, not any Node:https://w3c.github.io/webdriver/#dfn-internal-json-clone and there's an assert in the get or create a web element reference that the input is in fact an Element: https://w3c.github.io/webdriver/#dfn-get-or-create-a-web-element-reference

The spec could change here of course, but as it stands at present these tests are correct.

whimboo · 2025-10-20T09:27:14Z

The WebDriver spec seems very clear here, in the serializer we explicitly switch on whether the input object is an Element, not any Node:https://w3c.github.io/webdriver/#dfn-internal-json-clone and there's an assert in the get or create a web element reference that the input is in fact an Element: https://w3c.github.io/webdriver/#dfn-get-or-create-a-web-element-reference

Please note that the changes for the wpt tests are related to enumerable properties. This code we only hit in the fallback code for plain objects which are not considered Elements.

2. Remove test unrelated to node Signed-off-by: Euclid Ye <[email protected]>

Signed-off-by: Euclid Ye <[email protected]>

servo-wpt-sync · 2025-10-21T03:40:57Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55534).

servo-wpt-sync · 2025-10-21T03:44:18Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#55534) title and body.

jdm

Why are the two test files testing different things now?

yezhizhen · 2025-10-21T04:08:48Z

Why are the two test files testing different things now?

Oh because I forgot to update the other one!
Will change later...

Signed-off-by: Euclid Ye <[email protected]>

servo-wpt-sync · 2025-10-21T05:49:08Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55534).

servo-wpt-sync · 2025-10-21T05:59:03Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#55534) title and body.

whimboo · 2025-10-21T06:31:08Z

Hm, what is the difference to #39988 which I just reviewed? It seems to map to web-platform-tests/wpt#55534 as well.

yezhizhen · 2025-10-21T07:17:21Z

Hm, what is the difference to #39988 which I just reviewed? It seems to map to web-platform-tests/wpt#55534 as well.

It is the same, except some internal Servo manifest file update, which would be excluded by wpt-export bot.

Once you are satisifed and approve the upstream, I can find someone to stamp this which automatically merge the upstream as well.

servo-wpt-sync · 2025-10-21T07:19:55Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55534).

Signed-off-by: Euclid Ye <[email protected]>

servo-wpt-sync · 2025-10-21T07:48:51Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55534).

servo-wpt-sync · 2025-10-21T07:51:53Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55534).

Signed-off-by: Euclid Ye <[email protected]>

servo-wpt-sync · 2025-10-21T09:01:28Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55534).

Signed-off-by: Euclid Ye <[email protected]>

servo-wpt-sync · 2025-10-22T04:01:46Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55534).

Signed-off-by: Euclid Ye <[email protected]>

servo-wpt-sync · 2025-10-22T06:33:04Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55534).

servo-wpt-sync · 2025-10-22T06:36:55Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#55534) title and body.

Signed-off-by: Euclid Ye <[email protected]>

servo-wpt-sync · 2025-10-22T12:07:47Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55534).

#39988 replaced these faulty tests with another set of tests and we've been fully passing them. Somehow this is not caught by CI/expectation update script. Signed-off-by: Euclid Ye <[email protected]>

yezhizhen requested a review from xiaochengh October 19, 2025 14:19

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 19, 2025

yezhizhen changed the title ~~webdriver: Remove outdated script execution tests to align spec~~ webdriver: Remove outdated script execution tests to align with spec Oct 19, 2025

Update outdated test to align spec

dbd4f23

Signed-off-by: Euclid <[email protected]>

yezhizhen force-pushed the update-wpt branch from 0bde666 to dbd4f23 Compare October 19, 2025 14:22

servo-wpt-sync mentioned this pull request Oct 19, 2025

wdspec tests: Check correct node type instead of asserting error for script execution web-platform-tests/wpt#55534

Merged

Update manifest

23c3b11

Signed-off-by: Euclid <[email protected]>

yezhizhen added 4 commits October 21, 2025 11:22

1. Test node type instead of removing all

cbff4b7

2. Remove test unrelated to node Signed-off-by: Euclid Ye <[email protected]>

Fix test that never selected anything correctly

b7f093c

Signed-off-by: Euclid Ye <[email protected]>

Cdata test

1249640

Signed-off-by: Euclid Ye <[email protected]>

Update manifest again

527635a

Signed-off-by: Euclid Ye <[email protected]>

yezhizhen changed the title ~~webdriver: Remove outdated script execution tests to align with spec~~ webdriver: Check correct node type instead of asserting error Oct 21, 2025

yezhizhen changed the title ~~webdriver: Check correct node type instead of asserting error~~ wdspec tests: Check correct node type instead of asserting error Oct 21, 2025

servo deleted a comment from servo-wpt-sync Oct 21, 2025

jdm reviewed Oct 21, 2025

View reviewed changes

Update async test symetrically

925347f

Signed-off-by: Euclid Ye <[email protected]>

yezhizhen changed the title ~~wdspec tests: Check correct node type instead of asserting error~~ wdspec tests: Check correct node type instead of asserting error for script execution Oct 21, 2025

yezhizhen force-pushed the update-wpt branch from 8dccc99 to 0e1d6de Compare October 21, 2025 07:45

Remove unused test and reduce duplication

a4feff8

Signed-off-by: Euclid Ye <[email protected]>

yezhizhen force-pushed the update-wpt branch from 0e1d6de to a4feff8 Compare October 21, 2025 07:46

dummy commit to check web-platform-tests/wpt#55534 (comment)

18ea840

Signed-off-by: Euclid Ye <[email protected]>

Revert some changes and check enumerable serialization

7aa2f33

Signed-off-by: Euclid Ye <[email protected]>

Reordeing assertions

47dbd2b

Signed-off-by: Euclid Ye <[email protected]>

minor adjustment

98d9f80

Signed-off-by: Euclid Ye <[email protected]>

jdm approved these changes Oct 23, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 23, 2025

jdm added this pull request to the merge queue Oct 23, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 23, 2025

Merged via the queue into main with commit 8a81848 Oct 23, 2025
30 checks passed

jdm deleted the update-wpt branch October 23, 2025 03:27

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 23, 2025

yezhizhen mentioned this pull request Oct 30, 2025

wpt: Remove unused files for the WebDriver conformance suite #40285

Merged

yezhizhen mentioned this pull request Jan 4, 2026

webdriver: Fix outdated timeouts test and remove redundant check #41631

Merged

Uh oh!

Conversation

yezhizhen commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

servo-wpt-sync commented Oct 19, 2025

Uh oh!

jgraham commented Oct 20, 2025

Uh oh!

whimboo commented Oct 20, 2025

Uh oh!

servo-wpt-sync commented Oct 21, 2025

Uh oh!

servo-wpt-sync commented Oct 21, 2025

Uh oh!

jdm left a comment

Choose a reason for hiding this comment

Uh oh!

yezhizhen commented Oct 21, 2025

Uh oh!

servo-wpt-sync commented Oct 21, 2025

Uh oh!

servo-wpt-sync commented Oct 21, 2025

Uh oh!

whimboo commented Oct 21, 2025

Uh oh!

yezhizhen commented Oct 21, 2025

Uh oh!

servo-wpt-sync commented Oct 21, 2025

Uh oh!

servo-wpt-sync commented Oct 21, 2025

Uh oh!

servo-wpt-sync commented Oct 21, 2025

Uh oh!

servo-wpt-sync commented Oct 21, 2025

Uh oh!

servo-wpt-sync commented Oct 22, 2025

Uh oh!

servo-wpt-sync commented Oct 22, 2025

Uh oh!

servo-wpt-sync commented Oct 22, 2025

Uh oh!

servo-wpt-sync commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yezhizhen commented Oct 19, 2025 •

edited

Loading