xpath: Replace nom with hand-written parsing rules#39977
Merged
simonwuelker merged 3 commits intoservo:mainfrom Oct 25, 2025
Merged
xpath: Replace nom with hand-written parsing rules#39977simonwuelker merged 3 commits intoservo:mainfrom
nom with hand-written parsing rules#39977simonwuelker merged 3 commits intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
simonwuelker
force-pushed
the
xpath-parser
branch
3 times, most recently
from
0eec400 to
cce86fa
Compare
|
🔨 Triggering try run (#18617320802) for OpenHarmony |
Bencher Report
|
✨ Try run (#18617320802) succeeded. |
simonwuelker
force-pushed
the
xpath-parser
branch
from
cce86fa to
4e37611
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
…40103) This change was split of from #39977 to make that PR easier to review. The `Debug` impl for the error is not very useful yet, but #39977 swaps out the error type itself, so there's no point in improving it here. Testing: I've manually tested that the error message appears. I don't think we have tests for error messages. Part of #34527 Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
xpath-parser
branch
from
4e37611 to
b398c35
Compare
servo-highfive
removed
the
S-awaiting-review
Contributor
Author
|
Thanks for the review! |
servo-highfive
added
S-needs-rebase
Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
xpath-parser
branch
from
c4957f9 to
4e58f1c
Compare
simonwuelker
force-pushed
the
xpath-parser
branch
from
4e58f1c to
3435031
Compare
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
removed
the
S-awaiting-merge
servo-highfive
added
the
S-tests-failed
servo-highfive
added
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
simonwuelker
force-pushed
the
xpath-parser
branch
from
3435031 to
8d60fed
Compare
servo-highfive
removed
the
S-tests-failed
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
xpath-parser
branch
from
8d60fed to
6da6678
Compare
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Member
|
Thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new parser is more verbose, but also more correct and easier to reason about. Apologies for the size of the change, I don't think there's an alternative to swapping out the entire parser at once.
Testing: Covered by existing tests, new tests also start to pass
Fixes #38552
Fixes #38553
Fixes #39596
Closes #39602
Part of #34527