layout: Handle `<select>` as a widget by Loirooriol · Pull Request #39970 · servo/servo

Loirooriol · 2025-10-17T21:29:36Z

For example, it will now be atomic with display: inline, so its block-level contents won't be able to split it, and it will be transformable.

Testing: Adding new test
Fixes: #39927

github-actions · 2025-10-17T21:29:53Z

🔨 Triggering try run (#18605326643) for Linux (WPT)

github-actions · 2025-10-17T21:53:17Z

Test results for linux-wpt from try job (#18605326643):

Flaky unexpected result (28)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
FAIL [expected PASS] /css/CSS2/css1/c5505-mrgn-001.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-copyright-022.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-credits-002.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-extension-032.xht (#39801)
FAIL [expected PASS] /css/WOFF2/tabledata-decompressed-length-003.xht (#39667)
OK /css/css-cascade/layer-font-face-override.html (#35935)
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 1
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 2
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
FAIL [expected PASS] /css/css-fonts/font-palette-30.html
FAIL [expected PASS] /css/css-sizing/hori-block-size-small-or-larger-than-container-with-min-or-max-content-2a.html
FAIL [expected PASS] /css/css-text/i18n/css3-text-line-break-opclns-139.html
OK /css/css-text/i18n/other-lang/css-text-line-break-de-cpm-loose.html
- FAIL [expected PASS] subtest: 203C DOUBLE EXCLAMATION MARK may NOT appear at line start if de and loose
```
assert_approx_equals: expected 99 +/- 1 but got 84
```
PASS [expected FAIL] /css/selectors/invalidation/any-link-attribute-removal.html (#35054)
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-mode - Not sent to non-trustworthy same-site destination
```
Test timed out
```
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
TIMEOUT /html/browsers/history/the-history-interface/001.html (#12580)
- FAIL [expected PASS] subtest: traversing history must also traverse hash changes
```
assert_equals: (this could cause other failures later on) expected "" but got "test"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work.
```
Test timed out
```
OK /html/webappapis/user-prompts/print-during-unload.html (#35944)
- PASS [expected FAIL] subtest: print() during unload
OK /preload/link-header-preload-delay-onload.html (#39622)
- FAIL [expected PASS] subtest: Makes sure that Link headers preload resources and block window.onload after resource discovery
```
assert_true: expected true got false
```

OK /preload/preload-error.sub.html (#37177)

FAIL [expected PASS] subtest: success (fetch): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?label=fetch should be loaded expected a number greater than 0 but got 0

PASS [expected FAIL] subtest: CORS (fetch): main

OK [expected ERROR] /webxr/render_state_update.https.html (#27535)

Stable unexpected results that are known to be intermittent (25)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #45
- PASS [expected FAIL] subtest: WebGL test #47
- PASS [expected FAIL] subtest: WebGL test #49
- PASS [expected FAIL] subtest: WebGL test #51
- FAIL [expected PASS] subtest: WebGL test #53
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #55
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #57
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #59
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- PASS [expected FAIL] subtest: WebGL test #61
- PASS [expected FAIL] subtest: WebGL test #63
- And 6 more unexpected results...
OK /css/css-animations/event-order.tentative.html (#39000)
- PASS [expected FAIL] subtest: Same events on pseudo-elements follow the prescribed order
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
```
assert_equals: quoted serif matches  @font-face rule expected 125 but got 40
```
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Newline normalization - \r\n in value (formdata)
OK [expected TIMEOUT] /fetch/fetch-later/activate-after.https.window.html (#39765)
- PASS [expected TIMEOUT] subtest: fetchLater() sends out based on activateAfter, even if document is in BFCache.
OK [expected TIMEOUT] /fetch/fetch-later/send-on-deactivate.https.window.html (#39628)
- PASS [expected TIMEOUT] subtest: fetchLater() sends on page entering BFCache if BackgroundSync is off.
- PASS [expected TIMEOUT] subtest: Call fetchLater() when BFCached with activateAfter=0 sends immediately.
- FAIL [expected TIMEOUT] subtest: fetchLater() sends on navigating away a page w/o BFCache.
```
assert_equals: expected (object) object "[object Object]" but got (undefined) undefined
```
- FAIL [expected TIMEOUT] subtest: fetchLater() does not send aborted request on navigating away a page w/o BFCache.
```
assert_equals: expected (object) object "[object Object]" but got (undefined) undefined
```
- FAIL [expected TIMEOUT] subtest: fetchLater() with activateAfter=1m sends on page entering BFCache if BackgroundSync is off.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-dest
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-user
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;input autofocus=""&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

assert_equals: expected Element node &lt;area autofocus="" href="/common/blank.html"&gt;&lt;/area&gt; but got Element node &lt;body&gt;
&lt;img src="/media/poster.png" usemap="#map"&gt;
&lt;map n...

OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic test (normal form)
```
assert_equals: expected "basic=test" but got ""
```
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
OK /trusted-types/trusted-types-navigation.html?21-25 (#38997)
- FAIL [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- FAIL [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /webdriver/tests/classic/dismiss_alert/dismiss.py (#39098)
- PASS [expected FAIL] subtest: test_dismiss_in_popup_window

github-actions · 2025-10-17T21:53:26Z

✨ Try run (#18605326643) succeeded.

nicoburns · 2025-10-19T17:46:59Z

Do you know why widgets like this don't just use inline-block? Is it just a historical thing?

Loirooriol · 2025-10-19T18:19:11Z

On Servo it has inline-block by default. It should just keep being atomic with inline.

Loirooriol · 2025-10-19T19:38:50Z

And if you meant display: inline-block !important in UA origin, that would prevent authors from using display: block if they want block-level widgets.

nicoburns · 2025-10-19T19:49:07Z

I see, so this is about what happens if the user overrides the style to inline

For example, it will now be atomic with `display: inline`, so its block-level contents won't be able to split it. Signed-off-by: Oriol Brufau <[email protected]>

servo-wpt-sync · 2025-10-20T09:59:14Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#55541) with upstreamable changes.

servo-wpt-sync · 2025-10-20T10:00:08Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#55541) title and body.

Loirooriol added A-layout/2020 https://github.com/servo/servo/wiki/Layout-2020 T-linux-wpt Do a try run of the WPT labels Oct 17, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Oct 17, 2025

layout: Handle <select> as a widget

8c0262e

For example, it will now be atomic with `display: inline`, so its block-level contents won't be able to split it. Signed-off-by: Oriol Brufau <[email protected]>

Loirooriol force-pushed the select-widget branch from 66671db to 8c0262e Compare October 20, 2025 09:56

Loirooriol marked this pull request as ready for review October 20, 2025 09:58

Loirooriol requested a review from mrobinson as a code owner October 20, 2025 09:58

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 20, 2025

servo-wpt-sync mentioned this pull request Oct 20, 2025

layout: Handle <select> as a widget web-platform-tests/wpt#55541

Merged

mrobinson approved these changes Oct 22, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 22, 2025

mrobinson added this pull request to the merge queue Oct 22, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 22, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2025

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 22, 2025

Loirooriol added this pull request to the merge queue Oct 22, 2025

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 22, 2025

Merged via the queue into servo:main with commit efc8c0f Oct 22, 2025
40 checks passed

Loirooriol deleted the select-widget branch October 22, 2025 15:41

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

layout: Handle `<select>` as a widget#39970

layout: Handle `<select>` as a widget#39970
Loirooriol merged 1 commit intoservo:mainfrom
Loirooriol:select-widget

Loirooriol commented Oct 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

nicoburns commented Oct 19, 2025

Uh oh!

Loirooriol commented Oct 19, 2025

Uh oh!

Loirooriol commented Oct 19, 2025

Uh oh!

nicoburns commented Oct 19, 2025

Uh oh!

servo-wpt-sync commented Oct 20, 2025

Uh oh!

servo-wpt-sync commented Oct 20, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Loirooriol commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

nicoburns commented Oct 19, 2025

Uh oh!

Loirooriol commented Oct 19, 2025

Uh oh!

Loirooriol commented Oct 19, 2025

Uh oh!

nicoburns commented Oct 19, 2025

Uh oh!

servo-wpt-sync commented Oct 20, 2025

Uh oh!

servo-wpt-sync commented Oct 20, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Loirooriol commented Oct 17, 2025 •

edited

Loading