constellation: Update the stored URL when discarding a document.#39941
Merged
jdm merged 1 commit intoservo:mainfrom Oct 18, 2025
Merged
constellation: Update the stored URL when discarding a document.#39941jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
This was referenced Oct 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
…9943) This way we have full coverage on WPT rather than the specific folders with tests. The timeout in `/performance-timeline/` will be addressed by #39941. The timeout under `/webmessaging/` [makes us match all other browsers](https://wpt.fyi/results/webmessaging/message-channels/close-event/document-destroyed.tentative.window.html?label=experimental&label=master&aligned). Testing: Lots of new passing tests. Fixes: #39904 Fixes: #39513 Signed-off-by: Tim van der Lippe <[email protected]> Signed-off-by: Josh Matthews <[email protected]> Co-authored-by: Tim van der Lippe <[email protected]>
|
🔨 Triggering try run (#18610607867) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18610607867): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (28)
Stable unexpected results (2)
|
|
|
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Josh Matthews <[email protected]>
84b0a6c to
4540558
Compare
|
🔨 Triggering try run (#18611458156) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18611458156): Flaky unexpected result (27)
Stable unexpected results that are known to be intermittent (28)
|
|
✨ Try run (#18611458156) succeeded. |
mrobinson
approved these changes
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When discarding a document, we need to ensure that any attempt to traverse the session history ends up navigating to the most recent URL associated with that document.
Testing: New tests running to completion.
Fixes: #39903