script: use run_a_classic_script algorithm for worker scripts#39905
Merged
jdm merged 8 commits intoservo:mainfrom Oct 21, 2025
Merged
script: use run_a_classic_script algorithm for worker scripts#39905jdm merged 8 commits intoservo:mainfrom
run_a_classic_script algorithm for worker scripts#39905jdm merged 8 commits intoservo:mainfrom
Conversation
Contributor
Author
|
I wasn't able to do a wpt run inside my fork, it would get stuck inside |
|
🔨 Triggering try run (#18543155941) for Linux (WPT) |
|
|
… execute_script use encoding_rs to utf_8 decode fetch response Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
|
🔨 Triggering try run (#18553864380) for Linux (WPT) |
mrobinson
reviewed
Oct 16, 2025
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
…alscope Signed-off-by: Gae24 <[email protected]>
Gae24
commented
Oct 17, 2025
Signed-off-by: Gae24 <[email protected]>
servo-highfive
added
the
S-awaiting-review
jdm
requested changes
Oct 17, 2025
Member
jdm
left a comment
jdm
left a comment
There was a problem hiding this comment.
This looks like a great improvement! We just need a small fix to get the unminifying working correctly, I think.
servo-highfive
added
S-needs-code-changes
Signed-off-by: Gae24 <[email protected]>
servo-highfive
added
S-awaiting-review
Contributor
Author
|
Now the first worker will get the |
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workers now call
run_a_classic_worker_script, also scripts gets unminified.Testing: no new tests passes are expected