script: Make file picker selection flow asynchronous by delan · Pull Request #39893 · servo/servo

delan · 2025-10-15T10:28:09Z

Previously the <input type=file> would wait synchronously for file selection
results from the embedder. This change moves that synchronous wait to the
FileManager worker thread. The main benefit is that script is not blocked waiting
for the embedder. The synchronous wait on the worker thread is not a large issue
because it is run from a thread pool, though a later change could also remove
that synchronous wait.

In addition, the API surface for file selection changes a bit as there is now a dismiss
method which differentiates between selecting no file and not making a choice at
all.

Testing: Covered by exiting WPT, WebDriver conformance, and unit tests.

github-actions · 2025-10-15T13:13:13Z

🔨 Triggering try run (#18530082150) for Linux (WPT)

github-actions · 2025-10-15T13:42:24Z

Test results for linux-wpt from try job (#18530082150):

Flaky unexpected result (34)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
OK /IndexedDB/idbobjectstore_get.any.worker.html (#38852)
- FAIL [expected PASS] subtest: Attempts to retrieve a record that doesn't exist
```
assert_unreached: unexpected open.success event Reached unreachable code
```
FAIL [expected PASS] /_mozilla/gfx-rs-gecko/descriptor-ranges.html (#23258)
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
FAIL [expected PASS] /css/CSS2/margin-padding-clear/margin-left-091.xht
FAIL [expected PASS] /css/CSS2/text/word-spacing-remove-space-006.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-copyright-021.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-extension-008.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-extension-038.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-license-013.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-trademark-006.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-well-formed-006.xht
PASS [expected FAIL] /css/css-fonts/font-palette-22.html
FAIL [expected PASS] /css/css-fonts/font-palette-25.html
PASS [expected FAIL] /css/css-fonts/system-ui-ja-vs-zh.html (#39601)
PASS [expected FAIL] /css/css-grid/grid-items/grid-auto-margin-and-replaced-item-001.html (#37162)
OK /css/css-text/i18n/zh/css-text-line-break-zh-in-normal.html
- FAIL [expected PASS] subtest: FE19 PRESENTATION FORM FOR VERTICAL HORIZONTAL ELLIPSIS may NOT appear at line start if zh and normal
```
assert_approx_equals: expected 99 +/- 1 but got 87
```
OK /css/css-text/i18n/zh/css-text-line-break-zh-po-strict.html
- FAIL [expected PASS] subtest: 00B0 DEGREE SIGN may NOT appear at line start if zh and strict
```
assert_approx_equals: expected 81 +/- 1 but got 84
```
TIMEOUT /fetch/fetch-later/send-on-deactivate.https.window.html (#39628)
- PASS [expected TIMEOUT] subtest: fetchLater() sends on page entering BFCache if BackgroundSync is off.
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
OK /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-from-document-networkState.html (#38980)
- FAIL [expected PASS] subtest: NOT invoking resource selection with implicit pause() when networkState is not NETWORK_EMPTY
```
assert_unreached: Reached unreachable code
```

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)

FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload

uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"

TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic test (normal form)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic test (normal form)
```
assert_equals: expected "basic=test" but got ""
```
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)
OK /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
TIMEOUT [expected OK] /webdriver/tests/classic/perform_actions/navigation.py (#38822)
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:

Stable unexpected results that are known to be intermittent (27)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
TIMEOUT [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
FAIL [expected PASS] /css/css-tables/paint/table-border-paint-caption-change.html (#38036)
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-dest
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
CRASH [expected TIMEOUT] /html/anonymous-iframe/indexeddb.tentative.https.window.html (#39254)
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
- PASS [expected FAIL] subtest: form submission

OK

/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html

(#29048)

FAIL [expected PASS] subtest: Navigating to a different document with location.href

assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"

FAIL [expected PASS] subtest: Navigating to a different document with location.assign

assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"

OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
```
assert_equals: expected "" but got "#fragment"
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Element with tabindex should support autofocus
```
Test timed out
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/webappapis/user-prompts/print-during-unload.html (#35944)
- PASS [expected FAIL] subtest: print() during unload
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
OK /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls in enforcing mode.
OK /webdriver/tests/classic/dismiss_alert/dismiss.py (#39098)
- PASS [expected FAIL] subtest: test_dismiss_in_popup_window

Stable unexpected results (1)

OK /webdriver/tests/classic/element_send_keys/file_upload.py
- FAIL [expected PASS] subtest: test_empty_text
```
assert 200 == 400
```
- FAIL [expected PASS] subtest: test_multiple_files_last_path_not_found
```
assert 200 == 400
```
- FAIL [expected PASS] subtest: test_multiple_files_send_twice
```
AssertionError: assert ['john', 'doe'] == ['foo', 'bar', 'john', 'doe']
```
- FAIL [expected PASS] subtest: test_single_file_appends_with_multiple_attribute
```
AssertionError: assert ['bar'] == ['foo', 'bar']
```

github-actions · 2025-10-15T13:42:35Z

⚠️ Try run (#18530082150) failed.

github-actions · 2025-10-17T10:11:00Z

🔨 Triggering try run (#18589548484) for Linux (WPT)

github-actions · 2025-10-17T10:39:42Z

Test results for linux-wpt from try job (#18589548484):

Flaky unexpected result (26)

OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
FAIL [expected PASS] /css/CSS2/positioning/abspos-inline-007.xht
FAIL [expected PASS] /css/CSS2/text/letter-spacing-applies-to-008.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-extension-029.xht
OK /css/css-cascade/layer-cssom-order-reverse.html (#36094)
- FAIL [expected PASS] subtest: Delete layer invalidates @font-face
```
assert_equals: expected "220px" but got "133px"
```
FAIL [expected PASS] /css/css-fonts/font-palette-26.html
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
```
assert_equals: quoted serif matches  @font-face rule expected 125 but got 40
```
PASS [expected FAIL] /css/css-fonts/system-ui-ja-vs-zh.html (#39601)
PASS [expected FAIL] /css/css-fonts/system-ui-zh.html (#39563)
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
- PASS [expected FAIL] subtest: Link with onclick form submit to javascript url with document.write and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- FAIL [expected PASS] subtest: load event does not fire on window.open('about:blank')
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
TIMEOUT /html/browsers/history/the-history-interface/001.html (#12580)
- FAIL [expected PASS] subtest: traversing history must also traverse hash changes
```
assert_equals: (this could cause other failures later on) expected "" but got "test"
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-nonexistent.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with non-existent fragments should work.
```
Test timed out
```
ERROR [expected OK] /html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html (#25046)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- FAIL [expected TIMEOUT] subtest: Sandboxed iframe can not navigate other frame's popup
```
assert_equals: expected "cannot navigate" but got "can navigate"
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#39878)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic test (normal form)

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

TIMEOUT [expected OK] /mixed-content/gen/top.http-rp/opt-in/audio-tag.https.html (#35744)
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
ERROR [expected OK] /workers/baseurl/alpha/sharedworker-in-worker.html (#21315)

Stable unexpected results that are known to be intermittent (29)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
TIMEOUT [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg 10deg' over 'oblique 5deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
FAIL [expected PASS] /css/css-text/letter-spacing/letter-spacing-211.html (#39600)
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
OK [expected TIMEOUT] /fetch/fetch-later/activate-after.https.window.html (#39765)
- PASS [expected TIMEOUT] subtest: fetchLater() sends out based on activateAfter, even if document is in BFCache.
OK [expected TIMEOUT] /fetch/fetch-later/send-on-deactivate.https.window.html (#39628)
- PASS [expected TIMEOUT] subtest: fetchLater() sends on page entering BFCache if BackgroundSync is off.
- PASS [expected TIMEOUT] subtest: Call fetchLater() when BFCached with activateAfter=0 sends immediately.
- FAIL [expected TIMEOUT] subtest: fetchLater() sends on navigating away a page w/o BFCache.
```
assert_equals: expected (object) object "[object Object]" but got (undefined) undefined
```
- FAIL [expected TIMEOUT] subtest: fetchLater() does not send aborted request on navigating away a page w/o BFCache.
```
assert_equals: expected (object) object "[object Object]" but got (undefined) undefined
```
- FAIL [expected TIMEOUT] subtest: fetchLater() with activateAfter=1m sends on page entering BFCache if BackgroundSync is off.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-dest
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-user
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

assert_equals: expected Element node &lt;area autofocus="" href="/common/blank.html"&gt;&lt;/area&gt; but got Element node &lt;body&gt;
&lt;img src="/media/poster.png" usemap="#map"&gt;
&lt;map n...

OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: Basic test (normal form)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic test (normal form)
```
assert_equals: expected "basic=test" but got ""
```
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)
OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.html (#33948)
- FAIL [expected PASS] subtest: Revoking a blob URL immediately after calling import will not fail
```
promise_test: Unhandled rejection with value: object "TypeError: Dynamic import failed"
```

OK /preload/preload-error.sub.html (#37177)

FAIL [expected PASS] subtest: success (fetch): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?label=fetch should be loaded expected a number greater than 0 but got 0

PASS [expected FAIL] subtest: CORS (fetch): main

OK /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- FAIL [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
TIMEOUT [expected OK] /webdriver/tests/classic/perform_actions/navigation.py (#38822)

github-actions · 2025-10-17T10:39:50Z

✨ Try run (#18589548484) succeeded.

delan · 2025-10-20T06:19:26Z

components/net/filemanager_thread.rs

            })
            .collect();

+        // WebDriver expects that if any of the files isn't found we don't select any files.


can we link to the spec or similar about this?

components/script/dom/html/htmlinputelement.rs

delan · 2025-10-20T06:51:10Z

ports/servoshell/desktop/dialog.rs

+                enum SelectFilesAction {
+                    Dismiss,
+                    Submit,
+                    Continue,


thanks for cleaning up the control flow here!

Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: delan azabani <[email protected]>

- Fix warnings - Fix FileManager unit test - Fix issues with WebDriver interaction with `<input type=file>` Signed-off-by: Martin Robinson <[email protected]>

Signed-off-by: Martin Robinson <[email protected]>

mrobinson force-pushed the async-input-type-file branch from 06cf707 to cdad6c4 Compare October 15, 2025 13:09

mrobinson added the T-linux-wpt Do a try run of the WPT label Oct 15, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Oct 15, 2025

mrobinson force-pushed the async-input-type-file branch from cdad6c4 to 27bbfe4 Compare October 15, 2025 13:17

mrobinson force-pushed the async-input-type-file branch 2 times, most recently from 5c6ae67 to fde08b8 Compare October 17, 2025 10:10

mrobinson added the T-linux-wpt Do a try run of the WPT label Oct 17, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Oct 17, 2025

delan commented Oct 20, 2025

View reviewed changes

mrobinson force-pushed the async-input-type-file branch from fde08b8 to 6462f62 Compare October 20, 2025 07:19

delan and others added 3 commits October 20, 2025 09:19

script: Make file picker selection flow asynchronous

7ca7835

Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: delan azabani <[email protected]>

Fix issues with PR

01b35bd

- Fix warnings - Fix FileManager unit test - Fix issues with WebDriver interaction with `<input type=file>` Signed-off-by: Martin Robinson <[email protected]>

Ensure that WebDriver responses are sent back asynchronously

22b9d8a

Signed-off-by: Martin Robinson <[email protected]>

mrobinson force-pushed the async-input-type-file branch from 6462f62 to 22b9d8a Compare October 20, 2025 07:19

mrobinson approved these changes Oct 20, 2025

View reviewed changes

mrobinson marked this pull request as ready for review October 20, 2025 07:19

mrobinson requested review from atbrakhi, gterzian and yezhizhen as code owners October 20, 2025 07:19

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 20, 2025

mrobinson enabled auto-merge October 20, 2025 07:19

mrobinson added this pull request to the merge queue Oct 20, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 20, 2025

Merged via the queue into main with commit 3fd9ebb Oct 20, 2025
34 checks passed

mrobinson deleted the async-input-type-file branch October 20, 2025 08:17

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

script: Make file picker selection flow asynchronous#39893

script: Make file picker selection flow asynchronous#39893
mrobinson merged 3 commits intomainfrom
async-input-type-file

delan commented Oct 15, 2025 •

edited by mrobinson

Loading

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

delan Oct 20, 2025

Uh oh!

Uh oh!

delan Oct 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

delan commented Oct 15, 2025 • edited by mrobinson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

delan Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

delan Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

delan commented Oct 15, 2025 •

edited by mrobinson

Loading