servoshell/desktop: condition gamepad support on pref#39889
Merged
Taym95 merged 1 commit intoservo:mainfrom Oct 15, 2025
Merged
servoshell/desktop: condition gamepad support on pref#39889Taym95 merged 1 commit intoservo:mainfrom
Taym95 merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: gterzian <[email protected]>
servo-highfive
added
the
S-awaiting-review
jschwe
approved these changes
Oct 15, 2025
servo-highfive
removed
the
S-awaiting-review
Taym95
approved these changes
Oct 15, 2025
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In desktop servoshell, only initialize gamepad support if pref is on, in particular because gilrs spawns background threads which we don't need unless the pref is on(and which cannot be shutdown cleanly because they are outside of our reach). Note that gamepad is enabled by default, so avoiding the threads requires
dom_gamepad_enabled=false.Testing: Manual; gilrs threads abstent when running servo with
--pref dom_gamepad_enabled=falseFixes: #30849