ci: Use nextest --retries in CI#39817
Merged
yezhizhen merged 2 commits intoservo:mainfrom Oct 15, 2025
Merged
Conversation
Finegrained test timeout should be preferred over global timeouts. Signed-off-by: Jonathan Schwender <[email protected]>
ce696d6 to
68d2ab9
Compare
Pick the install-action before the `bootstrap` step On windows we don't do full bootstrap, so we stay with the existing logic. Signed-off-by: Jonathan Schwender <[email protected]>
yezhizhen
reviewed
Oct 15, 2025
yezhizhen
approved these changes
Oct 15, 2025
jschwe
added a commit
to jschwe/servo
that referenced
this pull request
Oct 26, 2025
The mac arm64 workflow was added after servo#39817, but we overlooked adding the change from servo#39817 to mac arm64. This PR fixes that, so we now consistently use the nextest retry mechanism for unit tests in CI. Signed-off-by: Jonathan Schwender <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
The mac arm64 workflow was added after #39817, but we overlooked adding the change from #39817 to mac arm64. This PR fixes that, so we now consistently use the nextest retry mechanism for unit tests in CI. Testing: Mac unitests in CI Signed-off-by: Jonathan Schwender <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39812, using nextests builtin retry feature to rerun flaky unit-tests.
This also adds a per-test timeout, replacing the global timeout set for the retry action. We could also add a global timeout for nextest tests, but per-test timeouts should be sufficient and noticably speedup CI when individual unit tests get stuck.
Testing: mach try running the unit-tests with retries in CI.