Skip to content

ci: Use nextest --retries in CI#39817

Merged
yezhizhen merged 2 commits intoservo:mainfrom
jschwe:jschwender/nextest_ci_retries
Oct 15, 2025
Merged

ci: Use nextest --retries in CI#39817
yezhizhen merged 2 commits intoservo:mainfrom
jschwe:jschwender/nextest_ci_retries

Conversation

@jschwe
Copy link
Copy Markdown
Member

@jschwe jschwe commented Oct 12, 2025

Follow-up to #39812, using nextests builtin retry feature to rerun flaky unit-tests.
This also adds a per-test timeout, replacing the global timeout set for the retry action. We could also add a global timeout for nextest tests, but per-test timeouts should be sufficient and noticably speedup CI when individual unit tests get stuck.

Testing: mach try running the unit-tests with retries in CI.

Finegrained test timeout should be preferred over global timeouts.

Signed-off-by: Jonathan Schwender <[email protected]>
@jschwe jschwe force-pushed the jschwender/nextest_ci_retries branch from ce696d6 to 68d2ab9 Compare October 14, 2025 20:53
@jschwe jschwe marked this pull request as ready for review October 14, 2025 20:54
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 14, 2025
Pick the install-action before the `bootstrap` step

On windows we don't do full bootstrap,
so we stay with the existing logic.

Signed-off-by: Jonathan Schwender <[email protected]>
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 15, 2025
@yezhizhen yezhizhen added this pull request to the merge queue Oct 15, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 15, 2025
Merged via the queue into servo:main with commit 8ec1e6e Oct 15, 2025
29 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 15, 2025
jschwe added a commit to jschwe/servo that referenced this pull request Oct 26, 2025
The mac arm64 workflow was added after servo#39817, but we
overlooked adding the change from servo#39817 to mac arm64.
This PR fixes that, so we now consistently use the
nextest retry mechanism for unit tests in CI.

Signed-off-by: Jonathan Schwender <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 26, 2025
The mac arm64 workflow was added after #39817, but we overlooked adding
the change from #39817 to mac arm64. This PR fixes that, so we now
consistently use the nextest retry mechanism for unit tests in CI.

Testing: Mac unitests in CI

Signed-off-by: Jonathan Schwender <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants