compositor: Remove the `CompositorMsg::TouchEventProcessed` message by mrobinson · Pull Request #39811 · servo/servo

mrobinson · 2025-10-12T08:56:06Z

The renderer needs needs to know when touch events processing has
finished in the DOM in order to properly handle them. This was
previously done using the CompositorMsg::TouchEventProcessed message.
This message is now redudant with the general-purpose
EmbedderMsg::InputEventHandled message.

This change removes the former message and instead, has the
TouchHandler keep a HashMap of pending touch events which is uses to
finish their processing when they come back from script. The goal here
is reduce the number of messages sent and to keep the complexity of
touch handling more centered in the TouchHandler.

Testing: This should not change observable behavior, so is covered by existing tests.

kongbai1996 · 2025-10-13T06:44:05Z

components/servo/lib.rs

+                    result,
+                );
+
                if let Some(webview) = self.get_webview_handle(webview_id) {


If the compositor consumes this input event, does it still need to be sent to the webview for processing?

Yes, this is to inform the embedder that the event was processed and handled so it can stop tracking it.

The renderer needs needs to know when touch events processing has finished in the DOM in order to properly handle them. This was previously done using the `CompositorMsg::TouchEventProcessed` message. This message is now redudant with the general-purpose `EmbedderMsg::InputEventHandled` message. This change removes the former message and instead, has the `TouchHandler` keep a `HashMap` of pending touch events which is uses to finish their processing when they come back from script. The goal here is reduce the number of messages sent and to keep the complexity of touch handling more centered in the `TouchHandler`. Signed-off-by: Martin Robinson <[email protected]>

github-actions · 2025-10-16T06:22:13Z

🔨 Triggering try run (#18552253136) for Linux (WPT)

github-actions · 2025-10-16T06:53:14Z

Test results for linux-wpt from try job (#18552253136):

Flaky unexpected result (27)

OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
TIMEOUT /IndexedDB/idbobjectstore_delete.any.html (#38904)
- FAIL [expected PASS] subtest: delete() key doesn't match any records
```
assert_unreached: unexpected open.success event Reached unreachable code
```
FAIL [expected PASS] /css/CSS2/linebox/vertical-align-applies-to-006.xht
FAIL [expected PASS] /css/CSS2/text/text-indent-112.xht
FAIL [expected PASS] /css/WOFF2/blocks-extraneous-data-005.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-description-018.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-license-030.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-vendor-008.xht
FAIL [expected PASS] /css/css-fonts/font-palette-11.html
FAIL [expected PASS] /css/css-fonts/font-palette-14.html
PASS [expected FAIL] /css/css-fonts/font-palette-3.html
FAIL [expected PASS] /css/css-fonts/font-palette.html
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-user - Not sent to non-trustworthy same-origin destination
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected FAIL] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html (#39694)
- PASS [expected FAIL] subtest: Meta refresh is blocked by the allow-scripts sandbox flag at its creation time, not when refresh comes due
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- FAIL [expected PASS] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
```
uncaught exception: Error: assert_unreached: The iframe into which the meta was moved must not refresh Reached unreachable code
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#39878)
- TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- PASS [expected FAIL] subtest: Verifies that location navigations take precedence when following form submissions.
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic test (normal form)
```
assert_equals: expected "basic=test" but got ""
```

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

TIMEOUT [expected OK] /mixed-content/gen/top.http-rp/opt-in/video-tag.https.html
OK /preload/preload-xhr.html (#39092)
- FAIL [expected PASS] subtest: Make an XHR request immediately after creating link rel=preload.
```
assert_equals: resources/dummy.xml?token=e837f614-2068-496a-8950-648191658d26 expected 1 but got 0
```
OK /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank

Stable unexpected results that are known to be intermittent (34)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

PASS [expected FAIL] subtest: IDBCursor update() method with throwing/invalid keys

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #45
- PASS [expected FAIL] subtest: WebGL test #47
- PASS [expected FAIL] subtest: WebGL test #49
- PASS [expected FAIL] subtest: WebGL test #51
- FAIL [expected PASS] subtest: WebGL test #53
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #55
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #57
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #59
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- PASS [expected FAIL] subtest: WebGL test #61
- PASS [expected FAIL] subtest: WebGL test #63
- And 18 more unexpected results...
OK /css/css-cascade/layer-font-face-override.html (#35935)
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 1
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 2
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
OK [expected TIMEOUT] /fetch/fetch-later/activate-after.https.window.html (#39765)
- PASS [expected TIMEOUT] subtest: fetchLater() sends out based on activateAfter, even if document is in BFCache.
OK [expected TIMEOUT] /fetch/fetch-later/send-on-deactivate.https.window.html (#39628)
- PASS [expected TIMEOUT] subtest: fetchLater() sends on page entering BFCache if BackgroundSync is off.
- PASS [expected TIMEOUT] subtest: Call fetchLater() when BFCached with activateAfter=0 sends immediately.
- FAIL [expected TIMEOUT] subtest: fetchLater() sends on navigating away a page w/o BFCache.
```
assert_equals: expected (object) object "[object Object]" but got (undefined) undefined
```
- FAIL [expected TIMEOUT] subtest: fetchLater() does not send aborted request on navigating away a page w/o BFCache.
```
assert_equals: expected (object) object "[object Object]" but got (undefined) undefined
```
- FAIL [expected TIMEOUT] subtest: fetchLater() with activateAfter=1m sends on page entering BFCache if BackgroundSync is off.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-dest
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
CRASH [expected TIMEOUT] /html/anonymous-iframe/indexeddb.tentative.https.window.html (#39254)
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout

OK

/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html

(#29048)

FAIL [expected PASS] subtest: Navigating to a different document with location.href

assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"

FAIL [expected PASS] subtest: Navigating to a different document with location.assign

assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"

OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Element with tabindex should support autofocus
```
Test timed out
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)
OK /html/webappapis/user-prompts/print-during-unload.html (#35944)
- PASS [expected FAIL] subtest: print() during unload
TIMEOUT [expected OK] /mixed-content/gen/top.http-rp/opt-in/audio-tag.https.html (#35744)
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```

OK /preload/preload-error.sub.html (#37177)

FAIL [expected PASS] subtest: success (fetch): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?label=fetch should be loaded expected a number greater than 0 but got 0

PASS [expected FAIL] subtest: CORS (fetch): main

TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
OK /trusted-types/trusted-types-navigation.html?21-25 (#38997)
- FAIL [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /webdriver/tests/classic/dismiss_alert/dismiss.py (#39098)
- PASS [expected FAIL] subtest: test_dismiss_in_popup_window
TIMEOUT [expected OK] /webdriver/tests/classic/perform_actions/navigation.py (#38822)

github-actions · 2025-10-16T06:53:24Z

✨ Try run (#18552253136) succeeded.

A recent PR (servo#39811) introduced an unconditional panic on touch events. This change fixes that issue.

A recent PR (servo#39811) introduced an unconditional panic on touch events. This change fixes that issue. Signed-off-by: Martin Robinson <[email protected]>

A recent PR (#39811) introduced an unconditional panic on touch events. This change fixes that issue. Testing: This can be verified manually by triggering any touch event. Signed-off-by: Martin Robinson <[email protected]>

mrobinson requested a review from gterzian as a code owner October 12, 2025 08:56

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 12, 2025

kongbai1996 reviewed Oct 13, 2025

View reviewed changes

mrobinson force-pushed the touch-events-notify-input-event branch from fe90a05 to 897ca9d Compare October 16, 2025 06:21

mrobinson added the T-linux-wpt Do a try run of the WPT label Oct 16, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Oct 16, 2025

mukilan approved these changes Oct 17, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 17, 2025

mrobinson added this pull request to the merge queue Oct 17, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 17, 2025

Merged via the queue into servo:main with commit f004e69 Oct 17, 2025
65 checks passed

mrobinson deleted the touch-events-notify-input-event branch October 17, 2025 17:26

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 17, 2025

kongbai1996 mentioned this pull request Oct 20, 2025

panic on on mobile devices #40016

Closed

mrobinson added a commit to mrobinson/servo that referenced this pull request Oct 20, 2025

compositor: Do not panic on touch events

2675cd9

A recent PR (servo#39811) introduced an unconditional panic on touch events. This change fixes that issue.

mrobinson mentioned this pull request Oct 20, 2025

compositor: Do not panic on touch events #40019

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

compositor: Remove the `CompositorMsg::TouchEventProcessed` message#39811

compositor: Remove the `CompositorMsg::TouchEventProcessed` message#39811
mrobinson merged 1 commit intoservo:mainfrom
mrobinson:touch-events-notify-input-event

mrobinson commented Oct 12, 2025

Uh oh!

kongbai1996 Oct 13, 2025

Uh oh!

mrobinson Oct 13, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mrobinson commented Oct 12, 2025

Uh oh!

kongbai1996 Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

mrobinson Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants