Adding message argument in WrongDocument Error#39773
Merged
Taym95 merged 3 commits intoservo:mainfrom Oct 12, 2025
Merged
Conversation
Signed-off-by: Ankur Gupta <[email protected]>
servo-highfive
added
the
S-awaiting-review
28 tasks
Taym95
reviewed
Oct 10, 2025
| Error::NotFound(None) => DOMErrorName::NotFoundError, | ||
| Error::HierarchyRequest => DOMErrorName::HierarchyRequestError, | ||
| Error::WrongDocument => DOMErrorName::WrongDocumentError, | ||
| Error::WrongDocument(Some(doc_err_custom_message)) => { |
Member
There was a problem hiding this comment.
can you use new_custom_exception?
Contributor
Author
There was a problem hiding this comment.
Hi Taym, this is taken care.
Signed-off-by: Ankur Gupta <[email protected]>
Signed-off-by: Ankur Gupta <[email protected]>
Taym95
approved these changes
Oct 12, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*This pull request address one of the action item of Provide messages in JS errors i.e. it adds message argument in WrongDocument Error *
Testing: This PR is tested using CLI ./mach test-unit -p libservo --jobs=3
Fixes: Provide messages in JS errors