html: Support selecting <media> element source from children#39717
Merged
jdm merged 1 commit intoservo:mainfrom Oct 9, 2025
Merged
html: Support selecting <media> element source from children#39717jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
Contributor
Author
|
JFYI < Almost all following tests were fixed, except the next:
|
|
🔨 Triggering try run (#18346035795) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18346035795): Flaky unexpected result (24)
Stable unexpected results that are known to be intermittent (31)
Stable unexpected results (11)
|
|
|
jdm
approved these changes
Oct 9, 2025
Member
jdm
left a comment
There was a problem hiding this comment.
Really great work! Thanks for all the new spec text comments.
Follow the HTML implemetation and support selection of the 'media' element loading source from 'source' children elements with validation processing over their 'media/src/type' attributes. See https://html.spec.whatwg.org/multipage/#concept-media-load-algorithm To handle loading with multiple 'source' children was introduced source children pointer to track the remaining unprocessed 'source' elements after the resource selection algorithm was invoked. Testing: Changes in the following tests with improvements: - html/semantics/embedded-content/media-elements/loading-the-media-resource/* - webgl/tests/conformance/textures/misc/texture-video-transparent.html with regressions (after enabled 'source' type attribute validation): - content-security-policy/media-src/media-src* - mixed-content/gen/top*audio|video-tag* - resource-timing/initiator-type/* Fixes: servo#21481 Fixes: servo#34127 Signed-off-by: Andrei Volykhin <[email protected]>
1baa765 to
32e4c0c
Compare
Contributor
Author
|
|
🔨 Triggering try run (#18374617701) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18374617701): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (1)
|
|
|
|
🔨 Triggering try run (#18378183381) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18378183381): Flaky unexpected result (27)
Stable unexpected results that are known to be intermittent (27)
|
|
✨ Try run (#18378183381) succeeded. |
This was referenced Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow the HTML implemetation and support selection of the 'media' element loading source from 'source' children elements with validation processing over their 'media/src/type' attributes.
See https://html.spec.whatwg.org/multipage/#concept-media-load-algorithm
To handle loading with multiple 'source' children was introduced source children pointer to track the remaining unprocessed 'source' elements after the resource selection algorithm was invoked.
Testing: Changes in the following tests
with improvements:
with regressions (after enabled 'source' type attribute validation):
Fixes: #21481
Fixes: #34127