compositor: Fix a performance regression from #39583#39684
Merged
mrobinson merged 1 commit intoservo:mainfrom Oct 6, 2025
Merged
compositor: Fix a performance regression from #39583#39684mrobinson merged 1 commit intoservo:mainfrom
mrobinson merged 1 commit intoservo:mainfrom
Conversation
When processing new WebRender frames after handling messages in the compositor, only do that when we actually receive `NewWebRenderFrameReady` messages. This isn't an issue unless there are active animations. When there are, every spin of the event loop was triggering a repaint. Signed-off-by: Martin Robinson <[email protected]> Co-authored-by: Delan Azabani <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
approved these changes
Oct 6, 2025
servo-highfive
removed
the
S-awaiting-review
delan
approved these changes
Oct 6, 2025
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When processing new WebRender frames after handling messages in the
compositor, only do that when we actually receive
NewWebRenderFrameReadymessages. This isn't an issue unless there areactive animations. When there are, every spin of the event loop was
triggering a repaint.
Testing: This should fix the performance regression on the Speedometer Bencher
benchmarks.
Fixes: #39641