webdriver: Implement Pointer ID#39642
Merged
yezhizhen merged 2 commits intoservo:mainfrom Oct 4, 2025
Merged
Conversation
Signed-off-by: Euclid Ye <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
commented
Oct 3, 2025
| } | ||
|
|
||
| /// <https://w3c.github.io/webdriver/#dfn-get-a-pointer-id> | ||
| pub(crate) fn get_pointer_id(subtype: PointerType, pointer_ids: FxHashSet<u32>) -> u32 { |
Member
Author
There was a problem hiding this comment.
Essentially mouse starts with 0, everything else starts with 2. New id to insert is the minimum possible one. But only god knows why it is designed like this.. This logic is not useful at all when multiple input sources are present....
Signed-off-by: Euclid Ye <[email protected]>
mrobinson
approved these changes
Oct 4, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
WaterWhisperer
added a commit
to WaterWhisperer/servo
that referenced
this pull request
Oct 5, 2025
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}]}
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary first step to distinguish pointer sources: "mouse, pen, touch".
Spec: https://w3c.github.io/webdriver/#dfn-get-a-pointer-id.
Testing: No behaviour change yet as we still only dispatch pointer type: mouse.
Fixes: Part of #39264.