html: Do not update the image data inside legacy <image> constructor#39635
Merged
sagudev merged 1 commit intoservo:mainfrom Oct 8, 2025
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
|
🔨 Triggering try run (#18193487623) for Linux (WPT) |
Contributor
Author
|
JFYI < The mentioned WPT decode test If replace the legacy constructor to HTML constructor this test will FAILED (without PR) |
|
Test results for linux-wpt from try job (#18193487623): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (34)
Stable unexpected results (2)
|
|
|
|
🔨 Triggering try run (#18194476562) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18194476562): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (31)
|
|
✨ Try run (#18194476562) succeeded. |
TimvdLippe
approved these changes
Oct 2, 2025
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Straightforward and nice addition of spec comments 😄
servo-highfive
removed
the
S-awaiting-review
Member
I think we should expend the test to test both cases? |
mrobinson
approved these changes
Oct 4, 2025
Member
The legacy 'image' constructor (new Image()) doesn't have any step in specification which require to run `update the image data` algorithm. See https://html.spec.whatwg.org/multipage/#dom-image This non-conformant behavior was added in the PR servo#31269 to follow https://html.spec.whatwg.org/multipage/#when-to-obtain-images (.. whenever that element is created or has experienced relevant mutations) to handle the edge case of `decode()` with 'image' without "src" and "srcset" attributes. See html/semantics/embedded-content/the-img-element/decode/image-decode.html#L87 Testing: No changes in test expectations Signed-off-by: Andrei Volykhin <[email protected]>
tharkum
force-pushed
the
html-image-legacy-constructor-and-decode
branch
from
0e0b3b8 to
65aec21
Compare
servo-highfive
added
the
S-awaiting-review
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#55305) with upstreamable changes. |
Contributor
Author
|
|
🔨 Triggering try run (#18347060959) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18347060959): Flaky unexpected result (38)
Stable unexpected results that are known to be intermittent (24)
|
|
✨ Try run (#18347060959) succeeded. |
sagudev
approved these changes
Oct 8, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Member
|
FYI, looking at the bencher.dev plot, this PR seems to have significantly reduced / improved memory usage on servo.org, and slightly on google.com (we don't test any other pages ATM): |
Contributor
Author
|
@jschwe < Sounds too good to be truth... I didn't see so much images on https://www.google.com to reduce memory footprint on 10 MB... I think the hero of the occasion is #39687 (pack of commits ~ 6months from upstream WebRender) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy 'image' constructor (new Image()) doesn't have any step in specification which require to run
update the image dataalgorithm.See https://html.spec.whatwg.org/multipage/#dom-image
This non-conformant behavior was added in the PR #31269 to follow https://html.spec.whatwg.org/multipage/#when-to-obtain-images (.. whenever that element is created or has experienced relevant mutations) to handle the edge case of
decode()with 'image' without "src" and "srcset" attributes.See html/semantics/embedded-content/the-img-element/decode/image-decode.html#L87
Testing: No changes in test expectations