Update expectations for --product servodriver#39603
Merged
Conversation
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Delan Azabani <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
approved these changes
Oct 1, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Member
Can you show how can I do the same? Run tests in CI and automatically update expectation only for those involve testdriver.js. |
Member
The process is still pretty manual and there are some scripts involved. I have a new batch of expectations that I hope to upload today. When I do that, I can try to post how I went about generating them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this patch updates the expectations for tests that use testdriver.js, which currently only work with
--product servodriver(#34683), running the tests with #39587.expectations for all other tests, which don’t use testdriver.js, are unaffected.
Testing: this patch updates test expectations, though the tests are not yet run in CI