Skip to content

script: move testbinding DOM interfaces to script/dom/test#39585

Merged
mrobinson merged 2 commits intoservo:mainfrom
Gae24:add-test-module
Sep 30, 2025
Merged

script: move testbinding DOM interfaces to script/dom/test#39585
mrobinson merged 2 commits intoservo:mainfrom
Gae24:add-test-module

Conversation

@Gae24
Copy link
Copy Markdown
Contributor

@Gae24 Gae24 commented Sep 30, 2025 •
edited
Loading

Move testbinding interfaces to it's own module, to avoid cluttering dom folder.

Testing: A successful build is enough
Part of #38901

@Gae24 Gae24 requested a review from gterzian as a code owner September 30, 2025 08:38
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 30, 2025
@Gae24
Copy link
Copy Markdown
Contributor Author

Gae24 commented Sep 30, 2025

Hm, what this file is used for?

servo/components/script/dom/test_mapping.json

Lines 1 to 8 in 91e4188

{
"xmlhttprequest.rs": [
"XMLHttpRequest"
],
"range.rs": [
"dom/ranges"
]
}

@mrobinson
Copy link
Copy Markdown
Member

mrobinson commented Sep 30, 2025

Hm, what this file is used for?

servo/components/script/dom/test_mapping.json

Lines 1 to 8 in 91e4188

{
"xmlhttprequest.rs": [
"XMLHttpRequest"
],
"range.rs": [
"dom/ranges"
]
}

https://github.com/servo/servo/blob/main/python/servo/mutation/README.md

mrobinson
mrobinson approved these changes Sep 30, 2025
View reviewed changes
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Sep 30, 2025
@Gae24
Copy link
Copy Markdown
Contributor Author

Gae24 commented Sep 30, 2025

Hm, what this file is used for?

servo/components/script/dom/test_mapping.json

Lines 1 to 8 in 91e4188

{
"xmlhttprequest.rs": [
"XMLHttpRequest"
],
"range.rs": [
"dom/ranges"
]
}

https://github.com/servo/servo/blob/main/python/servo/mutation/README.md

The file never had major additions, was this testing ever done?

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 30, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Sep 30, 2025
@mrobinson mrobinson enabled auto-merge September 30, 2025 09:47
@mrobinson
Copy link
Copy Markdown
Member

mrobinson commented Sep 30, 2025

The file never had major additions, was this testing ever done?

I'm not sure.

@jdm
Copy link
Copy Markdown
Member

jdm commented Sep 30, 2025

Hm, what this file is used for?

servo/components/script/dom/test_mapping.json

Lines 1 to 8 in 91e4188

{
"xmlhttprequest.rs": [
"XMLHttpRequest"
],
"range.rs": [
"dom/ranges"
]
}

https://github.com/servo/servo/blob/main/python/servo/mutation/README.md

The file never had major additions, was this testing ever done?

It used to run on our old buildbot CI for a couple years. It was never migrated, and we should clean it up.

@mrobinson mrobinson added this pull request to the merge queue Sep 30, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 30, 2025
Merged via the queue into servo:main with commit 5442302 Sep 30, 2025
28 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 30, 2025
@arihant2math arihant2math mentioned this pull request Oct 2, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 2, 2025
@arihant2math
Remove test_mapping.json and python/servo/mutation (#39617)
1448fd5 
As per #39585.

>It used to run on our old buildbot CI for a couple years. It was never
migrated, and we should clean it up.

_Originally posted by @jdm in
#39585 (comment)

---------

Signed-off-by: Ashwin Naren <[email protected]>
@Gae24 Gae24 deleted the add-test-module branch October 21, 2025 08:28
@arihant2math arihant2math mentioned this pull request Oct 23, 2025
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrobinson mrobinson mrobinson approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gae24 @mrobinson @jdm @servo-highfive