Consistently rename storage to webstorage to prevent confusion#39550
Merged
mrobinson merged 1 commit intoservo:mainfrom Sep 29, 2025
Merged
Consistently rename storage to webstorage to prevent confusion#39550mrobinson merged 1 commit intoservo:mainfrom
mrobinson merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
Signed-off-by: Ashwin Naren <[email protected]>
arihant2math
force-pushed
the
storage-rename
branch
from
bd6b7f0 to
4243ef8
Compare
yezhizhen
approved these changes
Sep 29, 2025
servo-highfive
removed
the
S-awaiting-review
arihant2math
added
the
S-awaiting-merge
servo-highfive
added
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
servo-highfive
removed
the
S-awaiting-merge
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Sep 30, 2025
…#39550) Add the prefix of "WebStorage" instead of "Storage" for all webstorage spec related things. For example, a `struct` called `StorageManager`: this could refer to either webstorage's thread manager or to the backend for [the storage manager interface](https://storage.spec.whatwg.org/#storagemanager). webstorage is the full name of the spec, so I chose to keep that in the names of files/structs to prevent confusion when storage manager is implemented. Signed-off-by: Ashwin Naren <[email protected]>
janvarga
added a commit
to janvarga/servo
that referenced
this pull request
Dec 19, 2025
This patch performs a remaining round of renaming in the web storage code to to avoid name conflicts with the newly introduced `StorageType` struct used by `SiteDataManager`. The change is a follow-up to PR servo#39550 and PR servo#40090 and does not introduce any functional changes.. Signed-off-by: Jan Varga <[email protected]>
janvarga
added a commit
to janvarga/servo
that referenced
this pull request
Dec 19, 2025
This patch performs a remaining round of renaming in the web storage code to to avoid name conflicts with the newly introduced `StorageType` struct used by `SiteDataManager`. The change is a follow-up to PR servo#39550 and PR servo#40090 and does not introduce any functional changes.. Signed-off-by: Jan Varga <[email protected]>
janvarga
added a commit
to janvarga/servo
that referenced
this pull request
Dec 19, 2025
This patch performs a remaining round of renaming in the web storage code to to avoid name conflicts with the newly introduced `StorageType` struct used by `SiteDataManager`. The change is a follow-up to PR servo#39550 and PR servo#40090 and does not introduce any functional changes.. Signed-off-by: Jan Varga <[email protected]>
janvarga
added a commit
to janvarga/servo
that referenced
this pull request
Dec 19, 2025
This patch performs a remaining round of renaming in the web storage code to to avoid name conflicts with the newly introduced `StorageType` struct used by `SiteDataManager`. The change is a follow-up to PR servo#39550 and PR servo#40090 and does not introduce any functional changes.. Signed-off-by: Jan Varga <[email protected]>
janvarga
added a commit
to janvarga/servo
that referenced
this pull request
Dec 20, 2025
This patch performs a remaining round of renaming in the web storage code to to avoid name conflicts with the newly introduced `StorageType` struct used by `SiteDataManager`. The change is a follow-up to PR servo#39550 and PR servo#40090 and does not introduce any functional changes.. Signed-off-by: Jan Varga <[email protected]>
janvarga
added a commit
to janvarga/servo
that referenced
this pull request
Dec 21, 2025
This patch performs a remaining round of renaming in the web storage code to to avoid name conflicts with the newly introduced `StorageType` struct used by `SiteDataManager`. The change is a follow-up to PR servo#39550 and PR servo#40090 and does not introduce any functional changes.. Signed-off-by: Jan Varga <[email protected]>
janvarga
added a commit
to janvarga/servo
that referenced
this pull request
Dec 21, 2025
This patch performs a remaining round of renaming in the web storage code to to avoid name conflicts with the newly introduced `StorageType` struct used by `SiteDataManager`. The change is a follow-up to PR servo#39550 and PR servo#40090 and does not introduce any functional changes.. Signed-off-by: Jan Varga <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the prefix of "WebStorage" instead of "Storage" for all webstorage spec related things. For example, a
structcalledStorageManager: this could refer to either webstorage's thread manager or to the backend for the storage manager interface. webstorage is the full name of the spec, so I chose to keep that in the names of files/structs to prevent confusion when storage manager is implemented.