webdriver: Wait animation frame callbacks before taking (element) screenshot#39539
Merged
jdm merged 2 commits intoservo:mainfrom Sep 27, 2025
Merged
webdriver: Wait animation frame callbacks before taking (element) screenshot#39539jdm merged 2 commits intoservo:mainfrom
jdm merged 2 commits intoservo:mainfrom
Conversation
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
commented
Sep 27, 2025
| if let Err(e) = response_sender.send(Err(())) { | ||
| error!("Sending reply to create png failed {e:?}"); | ||
| } | ||
| return; |
Member
Author
There was a problem hiding this comment.
Forgot to add this in #39499. We should early return if bounding rectangle has area 0.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to spec, we should wait animation frame callbacks before taking (element) screenshot. As "element screenshot" would automatically scroll into view, this solves intermittency.
Testing: Manually tested on pages, and
take_element_screenshot/scroll_into_view.pypasses stably now.Fixes: #39306