Skip to content

fonts: Initial draft of synthetic bold face for FreeType#39519

Merged
jdm merged 24 commits intoservo:mainfrom
minghuaw:feat/synth-bold-ft
Oct 1, 2025
Merged

fonts: Initial draft of synthetic bold face for FreeType#39519
jdm merged 24 commits intoservo:mainfrom
minghuaw:feat/synth-bold-ft

Conversation

@minghuaw
Copy link
Copy Markdown
Contributor

@minghuaw minghuaw commented Sep 26, 2025 •
edited
Loading

This is an initial attempt at implementing synthetic bold face for font families that lack actual bold faces. The overall approach borrowed implementations from Chromium and FireFox. WPT expectations will be updated after servo/stylo#244 lands

Testing: There are existing WPT testcases for font synthesis (wpt/css/css-fonts/font-synthesis-*)

Depends on: servo/stylo#244

@minghuaw
adding support of FontSynthesis for servo
4ecae0f 
Signed-off-by: Minghua Wu <[email protected]>
@minghuaw
copied mozilla_glyphslot_embolden_less temporarily
f6e1629 
Signed-off-by: Minghua Wu <[email protected]>
@minghuaw
import freetype temporarily
7417918 
Signed-off-by: Minghua Wu <[email protected]>
@minghuaw
remove freetype dep
ba0eddf 
Signed-off-by: Minghua Wu <[email protected]>
@minghuaw
embolden glyph for shaping
59801ee 
Signed-off-by: Minghua Wu <[email protected]>
@minghuaw
temporarily use git dep for stylo
3b15b15 
Signed-off-by: Minghua Wu <[email protected]>
@minghuaw
fmt
eb1149b 
Signed-off-by: Minghua Wu <[email protected]>
@minghuaw
fix unit test
03ab2e5 
Signed-off-by: Minghua Wu <[email protected]>
@minghuaw
update macos platformfont sig
e74eae5 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
update windodws platformfont sig
40e20d8 
Signed-off-by: Minghua Wu <[email protected]>
@minghuaw minghuaw requested a review from nicoburns as a code owner September 26, 2025 16:58
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Sep 26, 2025
@minghuaw minghuaw marked this pull request as draft September 26, 2025 16:58
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Sep 26, 2025

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Sep 26, 2025

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

@minghuaw minghuaw changed the title fonts: Initial draft of synthetic bold face fonts: Initial draft of synthetic bold face for linux/freetype Sep 26, 2025
@minghuaw minghuaw mentioned this pull request Sep 28, 2025
Merged
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Sep 29, 2025

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

@minghuaw minghuaw marked this pull request as ready for review September 29, 2025 08:26
@servo-highfive servo-highfive removed the S-needs-rebase There are merge conflict errors. label Sep 29, 2025
jdm
jdm reviewed Sep 29, 2025
View reviewed changes
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Sep 29, 2025

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

@minghuaw
update unit tests
b5dd68a 
Signed-off-by: Minghua Wu <[email protected]>
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Sep 30, 2025

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Oct 1, 2025

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

minghuaw
minghuaw commented Oct 1, 2025
View reviewed changes
minghuaw
minghuaw commented Oct 1, 2025
View reviewed changes
@minghuaw
remove temporary changes
f0a821b 
Signed-off-by: Minghua Wu <[email protected]>
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Oct 1, 2025

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

@jdm jdm added this pull request to the merge queue Oct 1, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2025
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 1, 2025
@minghuaw
Copy link
Copy Markdown
Contributor Author

minghuaw commented Oct 1, 2025 •
edited
Loading

Tried to run WPT tests multiple times and some tests under /performance-timeline/not-restored-reasons/ seems flacky.

Link to WPT test attempts:

  1. https://github.com/minghuaw/servo/actions/runs/18161528419
  2. https://github.com/minghuaw/servo/actions/runs/18161529653
  3. https://github.com/minghuaw/servo/actions/runs/18161465995

@minghuaw
remove completed todo
38ca5de 
Signed-off-by: Minghua Wu <[email protected]>
@servo-highfive servo-highfive removed the S-tests-failed The changes caused existing tests to fail. label Oct 1, 2025
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Oct 1, 2025

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

@minghuaw
restore Cargo.toml
fa1835a 
Signed-off-by: Minghua Wu <[email protected]>
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Oct 1, 2025

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

@jdm jdm added this pull request to the merge queue Oct 1, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 1, 2025
@Loirooriol Loirooriol mentioned this pull request Oct 1, 2025
Merged
Merged via the queue into servo:main with commit bcd8bbb Oct 1, 2025
25 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 1, 2025
@minghuaw minghuaw deleted the feat/synth-bold-ft branch October 2, 2025 01:14
This was referenced Oct 2, 2025
Merged
Open
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 7, 2025
@minghuaw @mrobinson
fonts: Use OS/2 table to determine if font face is already bold when …
81cd587 
…synthesizing bold face for FreeType platform (#39681)

The previous implementation in #39519 mistakenly used the
`FontTemplateDescriptor` to determine whether the font face itself is
already bold. This PR fixes that by using the `usWeightClass` in the
`OS/2` table of the font face to determine if the font face is bold
already.

Testing: A new testcase
`/tests/wpt/mozilla/tests/css/font_synthesis_weight_static_bold.html` is
getting added in #39633. This test checks whether a bold font face gets
"double emboldened"
Depends on: #39633

---------

Signed-off-by: Minghua Wu <[email protected]>
Signed-off-by: minghuaw <[email protected]>
Co-authored-by: Martin Robinson <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2025
@minghuaw
fonts: Add synthetic bold face support for macos (#39691)
fd30601 
This PR follows #39519 and adds
synthetic bold face support for MacOs platform.

Testing: There are existing WPT testcases for font synthesis
(wpt/css/css-fonts/font-synthesis-*). A new test checking that a bold
face font does not get "double emboldened" is getting added in #39713
Part of #39637

---------

Signed-off-by: minghuaw <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 10, 2025
@minghuaw
fonts: Add synthetic bold face support for Windows (#39633)
2f82537 
This PR follows #39519 and adds synthetic bold face support for Windows
platform.

Testing: There are existing WPT testcases for font synthesis
(wpt/css/css-fonts/font-synthesis-*). A new test that checks for "double
emboldening" (a bold font gets emboldened again) is getting added to the
upstream WPT repo (web-platform-tests/wpt#55313)
Depends on: servo/dwrote-rs#70,
servo/dwrote-rs#71
Part of #39637

---------

Signed-off-by: Minghua Wu <[email protected]>
Signed-off-by: minghuaw <[email protected]>
Co-authored-by: minghuaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm approved these changes

@nicoburns nicoburns Awaiting requested review from nicoburns nicoburns is a code owner

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@minghuaw @servo-wpt-sync @jdm @servo-highfive