webdriver: Elegantly handle "element screenshot" when bounding box has area zero#39499
Merged
jdm merged 1 commit intoservo:mainfrom Sep 27, 2025
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
yezhizhen
commented
Sep 26, 2025
| ))) | ||
| }, | ||
| Err(error) => Err(WebDriverError::new(error, "Element not found")), | ||
| Err(error) => Err(WebDriverError::new(error, "")), |
Member
Author
There was a problem hiding this comment.
It is possible that element is found but "stale".
Signed-off-by: Euclid Ye <[email protected]>
yezhizhen
force-pushed
the
fix-screenshot-synchronization
branch
from
853f91f to
81e742c
Compare
jdm
approved these changes
Sep 27, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible that the bounding rectangle of an element has area 0. This PR avoids panic in this case.
It is worth to mention that the panic itself won't kill the entire program for interaction, but only the webdriver thread.
Testing: Manually tested on the case of #39495