Add abort signal preference to experimental web features#39421
Merged
jdm merged 1 commit intoservo:mainfrom Sep 26, 2025
Merged
Add abort signal preference to experimental web features#39421jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#17892680788) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17892680788): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (27)
Stable unexpected results (38)
|
|
|
Member
|
The timeouts occur because of which can now execute without throwing a JS exception. I think it's worth it. |
c37b056 to
1f27f11
Compare
|
🔨 Triggering try run (#18017184495) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18017184495): Flaky unexpected result (33)
Stable unexpected results that are known to be intermittent (33)
Stable unexpected results (7)
|
|
|
This way we have full coverage on WPT rather than the specific folders with tests. Part of servo#34866 Signed-off-by: Tim van der Lippe <[email protected]>
1f27f11 to
6ac6ad0
Compare
|
🔨 Triggering try run (#18031063375) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18031063375): Flaky unexpected result (26)
Stable unexpected results that are known to be intermittent (26)
Stable unexpected results (1)
|
|
|
Contributor
Author
|
Filed #39503 for that |
jdm
approved these changes
Sep 26, 2025
Contributor
Author
|
Filed two intermittent issues for these failures |
This was referenced Sep 27, 2025
Member
|
As I checked, I already see 9 intermittent issues filed related to this. That's way too many and I think we should revert this for now. |
jdm
pushed a commit
to jdm/servo
that referenced
this pull request
Oct 17, 2025
This way we have full coverage on WPT rather than the specific folders with tests. Part of servo#34866 Signed-off-by: Tim van der Lippe <[email protected]>
jdm
pushed a commit
to jdm/servo
that referenced
this pull request
Oct 17, 2025
This way we have full coverage on WPT rather than the specific folders with tests. Part of servo#34866 Signed-off-by: Tim van der Lippe <[email protected]> Signed-off-by: Josh Matthews <[email protected]>
jdm
pushed a commit
to jdm/servo
that referenced
this pull request
Oct 17, 2025
This way we have full coverage on WPT rather than the specific folders with tests. Part of servo#34866 Signed-off-by: Tim van der Lippe <[email protected]> Signed-off-by: Josh Matthews <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
…9943) This way we have full coverage on WPT rather than the specific folders with tests. The timeout in `/performance-timeline/` will be addressed by #39941. The timeout under `/webmessaging/` [makes us match all other browsers](https://wpt.fyi/results/webmessaging/message-channels/close-event/document-destroyed.tentative.window.html?label=experimental&label=master&aligned). Testing: Lots of new passing tests. Fixes: #39904 Fixes: #39513 Signed-off-by: Tim van der Lippe <[email protected]> Signed-off-by: Josh Matthews <[email protected]> Co-authored-by: Tim van der Lippe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we have full coverage on WPT rather than the
specific folders with tests.
Part of #34866