indexeddb: Don't drop sender when registering txn if database doesn't exist#39278
Draft
arihant2math wants to merge 1 commit intoservo:mainfrom
Draft
indexeddb: Don't drop sender when registering txn if database doesn't exist#39278arihant2math wants to merge 1 commit intoservo:mainfrom
arihant2math wants to merge 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Ashwin Naren <[email protected]>
servo-highfive
added
the
S-awaiting-review
|
Heads up! This PR modifies the following files:
|
|
|
jdm
reviewed
Sep 12, 2025
| .unwrap(); | ||
|
|
||
| receiver.recv().unwrap() | ||
| receiver.recv().unwrap().unwrap() |
Member
There was a problem hiding this comment.
This just shifts the panic to another part of the engine. I'd prefer to make this method fallible.
Member
|
For clarity, what I wrote in the issue as the source of the panic being the dropping of the sender is not the ultimate problem, which is an unidentified race condition causing this dropping of the sender. We can remove the crash and log an error instead, but this Pr should not close the issue, until the actual race condition has been identified and resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why a database that doesn't exist is being passed in as a parameter needs to be investigated.
Testing: WPT
Fixes: #39254