fixup: Enable viewport <meta> tag support for mobile platforms only#39207
Merged
mukilan merged 5 commits intoservo:mainfrom Sep 11, 2025
Merged
fixup: Enable viewport <meta> tag support for mobile platforms only#39207mukilan merged 5 commits intoservo:mainfrom
mukilan merged 5 commits intoservo:mainfrom
Conversation
shubhamg13
requested review from
atbrakhi,
gterzian and
jschwe
as code owners
shubhamg13
force-pushed
the
viewport_support
branch
2 times, most recently
from
f7fde81 to
c6d4bb4
Compare
servo#39133)" This reverts commit 40ced5b. Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
shubhamg13
force-pushed
the
viewport_support
branch
2 times, most recently
from
604c277 to
29a7182
Compare
Member
Author
|
cc: @xiaochengh |
shubhamg13
force-pushed
the
viewport_support
branch
from
29a7182 to
f2baaa4
Compare
servo-highfive
added
the
S-awaiting-review
shubhamg13
force-pushed
the
viewport_support
branch
from
f2baaa4 to
1384cd8
Compare
shubhamg13
force-pushed
the
viewport_support
branch
3 times, most recently
from
5d38716 to
d0711c7
Compare
mukilan
reviewed
Sep 11, 2025
ports/servoshell/desktop/app.rs
Outdated
| // If the window is taller than it is wide, we need to enable the viewport meta tag. | ||
| // TODO: This is a hack to enable the viewport meta tag for mobile devices like PinePhone | ||
| // We should find a better way to do this. | ||
| if window.window_rect().size().height > window.window_rect().size().width { |
Member
There was a problem hiding this comment.
I agree with the comment here. This port is for desktops, so I don't think we should do this. The ports/embedders can always set the preference either using the API or the CLI if needed.
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
shubhamg13
force-pushed
the
viewport_support
branch
from
d0711c7 to
2a875de
Compare
mukilan
approved these changes
Sep 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Shubham Gupta <[email protected]>
shubhamg13
force-pushed
the
viewport_support
branch
from
2a875de to
bcb5d88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: Tested Manually
Fixes: #39157
Fixes: #39002