servoshell: Add button to toggle experimental web platform features.#39125
Merged
jdm merged 1 commit intoservo:mainfrom Sep 4, 2025
Merged
servoshell: Add button to toggle experimental web platform features.#39125jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Josh Matthews <[email protected]>
jdm
force-pushed
the
experimental-button
branch
from
07613de to
91c5811
Compare
yezhizhen
reviewed
Sep 4, 2025
Comment on lines
+353
to
+357
| for pref in EXPERIMENTAL_PREFS { | ||
| state | ||
| .servo() | ||
| .set_preference(pref, PrefValue::Bool(enable)); | ||
| } |
Member
There was a problem hiding this comment.
Is it possible to batch update this？
Member
Author
There was a problem hiding this comment.
It's possible to create an API that accepts &[(&str, PrefValue)], yes.
Member
There was a problem hiding this comment.
We can do this later then. I see some use
servo/components/config/macro/lib.rs
Line 53 in 912b83b
individually, but some in batch.
yezhizhen
approved these changes
Sep 4, 2025
Comment on lines
+353
to
+357
| for pref in EXPERIMENTAL_PREFS { | ||
| state | ||
| .servo() | ||
| .set_preference(pref, PrefValue::Bool(enable)); | ||
| } |
Member
There was a problem hiding this comment.
We can do this later then. I see some use
servo/components/config/macro/lib.rs
Line 53 in 912b83b
individually, but some in batch.
yezhizhen
added a commit
to yezhizhen/servo
that referenced
this pull request
Sep 4, 2025
…ervo#39125) (wd) {"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --processes 1", "number_of_wpt_chunks": 2}]}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to experiment with the impact of experimental features when browsing around in servoshell. The toggle is global and causes all webviews to reload with the new preference values.
Testing: Manually tested; no UI testing for servoshell.
Not enabled:
Enabled:
