indexeddb: Serialize all cloned values when storing data. by jdm · Pull Request #39081 · servo/servo

jdm · 2025-09-02T05:02:23Z

We were performing a structured clone but throwing away any serializable DOM interfaces included in the result. We need to instead serialize the full structured clone result so we can deserialize the DOM interfaces when getting the data out of the object store.

Testing: Existing WPT coverage is sufficient.
Fixes: #38818
Fixed: #38842

Signed-off-by: Josh Matthews <[email protected]>

github-actions · 2025-09-02T05:05:45Z

🔨 Triggering try run (#17393801638) for Linux (WPT)

github-actions · 2025-09-02T05:28:09Z

Test results for linux-wpt from try job (#17393801638):

Flaky unexpected result (21)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- PASS [expected FAIL] subtest: Revoke blob URL after calling fetch, fetch should succeed
OK /IndexedDB/idbfactory_open.any.worker.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
FAIL [expected PASS] /css/css-grid/subgrid/orthogonal-writing-mode-006.html
FAIL [expected PASS] /css/css-text/white-space/white-space-intrinsic-size-005.html
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- PASS [expected FAIL] subtest: sec-fetch-site - Same origin, no options - registration
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- PASS [expected FAIL] subtest: Link with onclick form submit to javascript url and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- FAIL [expected PASS] subtest: Check execution order from nested timeout
```
assert_equals: Expected nested setTimeout to run second expected true but got false
```
- FAIL [expected PASS] subtest: Check execution order on load handler
```
assert_equals: Expected onload to run first expected false but got true
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
CRASH [expected OK] /html/browsers/the-window-object/open-close/open-features-tokenization-screenx-screeny.html
OK /html/browsers/windows/browsing-context-names/duplicate-name-order.html (#34623)
- PASS [expected FAIL] subtest: Duplicate name lookup order
PASS [expected FAIL] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
PASS [expected FAIL] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- FAIL [expected TIMEOUT] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
assert_equals: expected "DIV" but got "BODY"
```
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
ERROR [expected OK] /html/semantics/embedded-content/the-video-element/video_crash_empty_src.html
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: Basic test (normal form)
OK /intersection-observer/callback-cross-realm-report-exception.html (#38829)
- FAIL [expected PASS] subtest: IntersectionObserver reports the exception from its callback in the callback's global object
```
assert_array_equals: lengths differ, expected array ["frame1"] length 1, got [] length 0
```

Stable unexpected results that are known to be intermittent (22)

OK /IndexedDB/transaction-deactivation-timing.any.html (#38772)
- FAIL [expected PASS] subtest: New transactions are deactivated before next task
```
assert_false: Transaction should be inactive in next task expected false got true
```
FAIL [expected PASS] /_mozilla/css/stacked_layers.html (#15988)
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 2
FAIL [expected PASS] /css/css-grid/grid-items/grid-auto-margin-and-replaced-item-001.html (#37162)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Same site
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- PASS [expected FAIL] subtest: Navigating to a different document with link click
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- FAIL [expected TIMEOUT] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work.
```
assert_not_equals: got disallowed value Element node &lt;body&gt;&lt;/body&gt;
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Element with tabindex should support autofocus
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Non-HTMLElement should not support autofocus
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
- NOTRUN [expected TIMEOUT] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730)
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```

OK /preload/preload-error.sub.html (#37177)

PASS [expected FAIL] subtest: CORS (style): main

FAIL [expected PASS] subtest: success (script): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.js?label=script should be loaded expected a number greater than 0 but got 0

PASS [expected FAIL] subtest: 404 (script): main

FAIL [expected PASS] subtest: 404 (xhr): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?pipe=status%28404%29&amp;label=xhr should be loaded expected a number greater than 0 but got 0

PASS [expected FAIL] subtest: Decode-error (style): main

FAIL [expected PASS] subtest: Decode-error (script): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?pipe=header%28Content-Type%2Ctext%2Fjavascript%29&amp;label=script should be loaded expected a number greater than 0 but got 0

FAIL [expected PASS] subtest: MIME-error (script): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.css?pipe=header%28Content-Type%2Ctext%2Fnotjavascript%29&amp;label=script should be loaded expected a number greater than 0 but got 0

OK /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls in enforcing mode.
- PASS [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
OK [expected CRASH] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
OK /trusted-types/trusted-types-navigation.html?21-25 (#38997)
- PASS [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in enforcing mode.
OK /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
- PASS [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
OK [expected CRASH] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- FAIL [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```

github-actions · 2025-09-02T05:28:17Z

✨ Try run (#17393801638) succeeded.

jdm requested a review from gterzian as a code owner September 2, 2025 05:02

indexeddb: Serialize all cloned values when storing data.

eb2f8d8

Signed-off-by: Josh Matthews <[email protected]>

jdm force-pushed the idb-blob-panic branch from d7c089a to eb2f8d8 Compare September 2, 2025 05:05

jdm added the T-linux-wpt Do a try run of the WPT label Sep 2, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Sep 2, 2025

arihant2math added the A-content/indexeddb IndexedDB implementation issues. label Sep 2, 2025

wusyong approved these changes Sep 3, 2025

View reviewed changes

jdm added this pull request to the merge queue Sep 3, 2025

Merged via the queue into servo:main with commit 433a461 Sep 3, 2025
59 checks passed

jdm deleted the idb-blob-panic branch September 3, 2025 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

indexeddb: Serialize all cloned values when storing data.#39081

indexeddb: Serialize all cloned values when storing data.#39081
jdm merged 1 commit intoservo:mainfrom
jdm:idb-blob-panic

jdm commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jdm commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants