Skip to content

renderer: Apply initial viewport scale to page_zoom.#39067

Closed
shubhamg13 wants to merge 2 commits intoservo:mainfrom
shubhamg13:fix_apply_viewport
Closed

renderer: Apply initial viewport scale to page_zoom.#39067
shubhamg13 wants to merge 2 commits intoservo:mainfrom
shubhamg13:fix_apply_viewport

Conversation

@shubhamg13
Copy link
Copy Markdown
Member

@shubhamg13 shubhamg13 commented Sep 1, 2025

Attached scenario in issue highlights that applying viewport scale needs reflow.
Hence applying it to page_zoom because we reflow for page_zoom.

Follow-Up: Ignore applying of viewport meta tag by default for desktop browsers.
Chromium and Firefox ignore in desktop browser, only enable in devtools. #39133

Testing: Manual Test Case using mobile size window dimensions.

Another Scenario verified using devtools: Page opened with initial scale=0.5 have 2x the width as compared with the page with initial-scale=1.0

Fixes: #39002

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#54619) with upstreamable changes.

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#54619).

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#54619).

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#54619) title and body.

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#54619).

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#54619).

@shubhamg13
Copy link
Copy Markdown
Member Author

cc: @xiaochengh

@shubhamg13 shubhamg13 marked this pull request as draft September 1, 2025 11:08
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

🤖 This change no longer contains upstreamable changes to WPT; closed existing upstream pull request (web-platform-tests/wpt#54619).

@shubhamg13 shubhamg13 marked this pull request as ready for review September 2, 2025 04:02
@mrobinson
Copy link
Copy Markdown
Member

Closing this as the issue that it was meant to fix is fixed now by another PR. @shubhamg13 feel to reopen this if you still think it is applicable. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<meta name=viewport> is applied when it shouldn't

3 participants