constellation: Optimize tracing of maybe_close_random_pipeline#39035
Merged
jschwe merged 1 commit intoservo:mainfrom Oct 24, 2025
Merged
Conversation
mrobinson
requested changes
Sep 1, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
I think I would prefer not to trace this function at all. It's just used for testing, so we shouldn't be too worried about the performance.
Most of the time this function does nothing and returns immediately, so there isn't really a point in tracing it. If one wanted to know when a pipeline is closed, one could add a trace point **after** the early return. However during review it was suggested that we currently don't need this information and thus just remove the trace. Signed-off-by: Jonathan Schwender <[email protected]>
jschwe
force-pushed
the
jschwender/trace_maybe_close_random_pipeline
branch
from
32989f6 to
77ecf7d
Compare
servo-highfive
added
the
S-awaiting-review
Member
Author
|
@mrobinson I came back to this PR, updated the description and just removed the trace point as you suggested. |
mrobinson
approved these changes
Oct 24, 2025
servo-highfive
removed
the
S-awaiting-review
Member
|
@jschwe Thanks! |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the time this function does nothing and returns immediately, so there isn't really a point in tracing it.
If one wanted to know when a pipeline is closed, one could add a trace point after the early return.
However, during review it was suggested that we currently don't need this information and thus just remove the trace.
Testing: Not required.