script: Prepare to run script and callback before invoking CE constructor#39013
Merged
simonwuelker merged 3 commits intoservo:mainfrom Oct 23, 2025
Merged
Conversation
|
🔨 Triggering try run (#17317787942) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17317787942): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (3)
|
|
|
1655ae5 to
5d64d10
Compare
|
🔨 Triggering try run (#17322804508) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17322804508): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (26)
Stable unexpected results (3)
|
|
|
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
9f83fa4 to
03fc173
Compare
|
🔨 Triggering try run (#18653423428) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18653423428): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (25)
Stable unexpected results (3)
|
|
|
mrobinson
approved these changes
Oct 22, 2025
Member
mrobinson
left a comment
There was a problem hiding this comment.
Looks reasonable to me. r+ with the test expectations updated.
Signed-off-by: Simon Wülker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, this change adjusts the step numbers around the code because they were outdated.
Testing: ???
Fixes #39004
Probably fixes #32977