script: Move gamepad DOM interfaces to script/dom/gamepad/#38900
Merged
jdm merged 1 commit intoservo:mainfrom Aug 27, 2025
Merged
script: Move gamepad DOM interfaces to script/dom/gamepad/#38900jdm merged 1 commit intoservo:mainfrom
script/dom/gamepad/#38900jdm merged 1 commit intoservo:mainfrom
Conversation
27 tasks
arihant2math
changed the title
script/dom/gamepad/
yezhizhen
reviewed
Aug 25, 2025
yezhizhen
reviewed
Aug 25, 2025
| @@ -324,11 +324,7 @@ pub(crate) mod fontfaceset; | |||
| pub(crate) mod formdata; | |||
| pub(crate) mod formdataevent; | |||
| pub(crate) mod gamepad; | |||
Member
There was a problem hiding this comment.
Suggested change
| pub(crate) mod gamepad; | |
| #[allow(clippy::module_inception)] | |
| pub(crate) mod gamepad; |
Should we do this instead? To make it same as bluetooth.
Member
There was a problem hiding this comment.
Why is this marked as resolved?
Member
There was a problem hiding this comment.
I think the current change makes more sense than the Bluetooth one since it only applies to the specific module that triggers the warning.
Member
There was a problem hiding this comment.
I see. Probably refactor bluetooth one later then.
tharkum
reviewed
Aug 25, 2025
Contributor
|
Have the missing changes in webXR been fixed with pub(crate) use gamepad::Gamepad; ? |
Signed-off-by: Ashwin Naren <[email protected]>
Contributor
Author
|
Should be good now. |
jdm
approved these changes
Aug 27, 2025
yezhizhen
approved these changes
Aug 27, 2025
| @@ -324,11 +324,7 @@ pub(crate) mod fontfaceset; | |||
| pub(crate) mod formdata; | |||
| pub(crate) mod formdataevent; | |||
| pub(crate) mod gamepad; | |||
Member
There was a problem hiding this comment.
I see. Probably refactor bluetooth one later then.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2025
…38974) As per discussion in #38900 Testing: None, minor refactor Signed-off-by: Ashwin Naren <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves interfaces defined by the gamepad spec to the
script/dom/gamepad/module fromscript/dom/.Testing: Just a refactor shouldn't need any testing
Fixes: N/A