-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Implement trusted types for remaining attribute sinks #38784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement trusted types for remaining attribute sinks #38784
Conversation
|
🔨 Triggering try run (#17075413903) for Linux (WPT) |
|
|
13a1c0e to
715ed43
Compare
|
🔨 Triggering try run (#17077138657) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17077138657): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (77)
|
|
|
Additionally, several methods were updated with spec comments. That's because the "adopt the document from the element document" step was missing. By adding these spec comments, I also restructured some code to avoid duplication of mutation records and custom element reaction queueing. Node.textContent doesn't propagate the error yet, as that method has a lot of separate callers of elements that wouldn't fail. I will refactor those in a follow-up PR to keep things manageable. This implements part of the DOM integration from whatwg/dom#1268 Part of servo#36258 Signed-off-by: Tim van der Lippe <[email protected]>
715ed43 to
4645cf7
Compare
|
🔨 Triggering try run (#17080100389) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17080100389): Flaky unexpected result (21)
Stable unexpected results that are known to be intermittent (22)
Stable unexpected results (1)
|
|
|
…t.window.js.ini Signed-off-by: Tim van der Lippe <[email protected]>
jdm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you for all the cleanup.
Failure in infrastructure? |
Additionally, several methods were updated with
spec comments. That's because the "adopt the document
from the element document" step was missing.
By adding these spec comments, I also restructured
some code to avoid duplication of mutation records
and custom element reaction queueing.
Node.textContent doesn't propagate the error yet,
as that method has a lot of separate callers of
elements that wouldn't fail. I will refactor those
in a follow-up PR to keep things manageable.
This implements part of the DOM integration from
whatwg/dom#1268
Part of #36258