webxr: Fix compile warning for Windows after upgrade to rustc 1.89#38780
Merged
sagudev merged 1 commit intoservo:mainfrom Aug 19, 2025
Merged
webxr: Fix compile warning for Windows after upgrade to rustc 1.89#38780sagudev merged 1 commit intoservo:mainfrom
sagudev merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Euclid Ye <[email protected]>
sagudev
approved these changes
Aug 19, 2025
mrobinson
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
PotatoCP
pushed a commit
to PotatoCP/servo
that referenced
this pull request
Aug 20, 2025
…ervo#38780) This is a follow up to servo#36818 (comment). Since openxr is a feature only available on Windows, it was omitted. Testing: Fixes ``` warning: hiding a lifetime that's elided elsewhere is confusing --> components\webxr\openxr\input.rs:366:9 | 366 | &self, | ^^^^^ the lifetime is elided here ... 371 | ) -> Vec<Binding> { | ------- the same lifetime is hidden here | = help: the same lifetime is referred to in inconsistent ways, making the signature confusing = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default help: use `'_` for type paths | 371 | ) -> Vec<Binding<'_>> { ``` Signed-off-by: Euclid Ye <[email protected]>
PotatoCP
pushed a commit
to PotatoCP/servo
that referenced
this pull request
Aug 20, 2025
…ervo#38780) This is a follow up to servo#36818 (comment). Since openxr is a feature only available on Windows, it was omitted. Testing: Fixes ``` warning: hiding a lifetime that's elided elsewhere is confusing --> components\webxr\openxr\input.rs:366:9 | 366 | &self, | ^^^^^ the lifetime is elided here ... 371 | ) -> Vec<Binding> { | ------- the same lifetime is hidden here | = help: the same lifetime is referred to in inconsistent ways, making the signature confusing = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default help: use `'_` for type paths | 371 | ) -> Vec<Binding<'_>> { ``` Signed-off-by: Euclid Ye <[email protected]>
PotatoCP
pushed a commit
to PotatoCP/servo
that referenced
this pull request
Aug 20, 2025
…ervo#38780) This is a follow up to servo#36818 (comment). Since openxr is a feature only available on Windows, it was omitted. Testing: Fixes ``` warning: hiding a lifetime that's elided elsewhere is confusing --> components\webxr\openxr\input.rs:366:9 | 366 | &self, | ^^^^^ the lifetime is elided here ... 371 | ) -> Vec<Binding> { | ------- the same lifetime is hidden here | = help: the same lifetime is referred to in inconsistent ways, making the signature confusing = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default help: use `'_` for type paths | 371 | ) -> Vec<Binding<'_>> { ``` Signed-off-by: Euclid Ye <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #36818 (comment). Since openxr is a feature only available on Windows, it was omitted.
Testing: Fixes