devtools: Warn when sending common protocol errors#38548
Merged
Conversation
Co-authored-by: atbrakhi <[email protected]> Signed-off-by: Delan Azabani <[email protected]>
mrobinson
approved these changes
Aug 8, 2025
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Delan Azabani <[email protected]>
delan
force-pushed
the
warn-on-devtools-protocol-errors
branch
from
b4c96b6 to
9026f05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#37686 fixed an entire class of devtools protocol bugs that led to protocol desyncs with warnings in the Servo log, but it also removed the warnings, making it harder to spot where our devtools impl is incomplete.
this patch reintroduces a warning whenever some Actor::handle_message() returns Err(ActorError).
Testing: debug logging only, so not really worth testing