canvas: Clear bitmap without transform#38286
Merged
sagudev merged 1 commit intoservo:mainfrom Nov 15, 2025
Merged
Conversation
|
🔨 Triggering try run (#16539201649) for Linux (WPT) |
|
Test results for linux-wpt from try job (#16539201649): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (21)
Stable unexpected results (4)
|
|
|
224cf18 to
8f81e0c
Compare
|
🔨 Triggering try run (#16541074129) for Linux (WPT) |
|
Test results for linux-wpt from try job (#16541074129): Flaky unexpected result (23)
Stable unexpected results that are known to be intermittent (19)
|
|
✨ Try run (#16541074129) succeeded. |
Member
|
Why not remove the transform argument from the IPC message itself? |
Member
Author
We still need it when calling clearRect and we cannot apply transform on rect (because skew). |
Signed-off-by: sagudev <[email protected]>
8f81e0c to
e0371ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only need to clear the viewport and with wrong transform this will not do.
Testing: Existing WPT tests