servoshell: Respond resize with authentic result and Adjust minimum window size#38258
Merged
jdm merged 4 commits intoservo:mainfrom Jul 25, 2025
Merged
servoshell: Respond resize with authentic result and Adjust minimum window size#38258jdm merged 4 commits intoservo:mainfrom
jdm merged 4 commits intoservo:mainfrom
Conversation
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
Member
Author
Some result for headed window after setting size to 10*10. `reply_rect` is our previous response, which just returns requested size. The second one is true size due to our restriction on inner size, which we're using now.
|
mrobinson
reviewed
Jul 25, 2025
Comment on lines
+779
to
+781
| i32::max( | ||
| MIN_INNER_HEIGHT, | ||
| (self.toolbar_height() * self.hidpi_scale_factor()).0 as i32, |
Member
There was a problem hiding this comment.
For the future, this can also be expressed more idiomatically like this:
MIN_INNER_HEIGHT.min((self.toolbar_height() * self.hidpi_scale_factor()).0 as i32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing:
./mach test-wpt -r "tests\wpt\tests\webdriver\tests\classic\set_window_rect\set.py" --log-raw "D:\servo test log\set.txt" --product servodriver {--headless}Fixes: #37804 as Task 8 is last task.