Merged
Conversation
Signed-off-by: maple! <[email protected]>
jdm
approved these changes
Jul 23, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
PotatoCP
added a commit
to PotatoCP/servo
that referenced
this pull request
Jul 24, 2025
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --product servodriver --headless --processes 1", "number_of_wpt_chunks": 2}]}
Member
|
Somehow Is the behaviour platform dependent? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously discussed in #38229. To recap:
badcert.jpgwas made unused in 8422dac andtumbeast.pngand its associated file ofnot-found.htmlwere superseded at some point by a message inneterror.html(if it were still used, it'd surely be embedded.)This PR also removes two unnecessary spaces inside of the new tab's CSS file, ensuring a consistent 2 space indentation in the file and saving 2 bytes.
Testing: Unnecessary, as this commit only removes unused assets (and fixes one style nit).