Optimize PNG images in resources folder#38229
Merged
jdm merged 1 commit intoservo:mainfrom Jul 23, 2025
Merged
Conversation
Signed-off-by: maple! <[email protected]>
Member
|
Yes, it would be good to remove resource files that are no longer used. |
jdm
approved these changes
Jul 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
As previously discussed in #38229. To recap: `badcert.jpg` was made unused in 8422dac and `tumbeast.png` and its associated file of `not-found.html` were superseded at some point by a message in `neterror.html` (if it were still used, it'd surely be [embedded](https://github.com/servo/servo/blob/main/components/shared/embedder/resources.rs).) This PR also removes two unnecessary spaces inside of the new tab's CSS file, ensuring a consistent 2 space indentation in the file and saving 2 bytes. Testing: Unnecessary, as this commit only removes unused assets (and fixes one style nit). Signed-off-by: maple! <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Losslessly optimizes the PNG images in the
resourcesfolder with:Tests are unaffected by this commit in order to avoid potential breakages.
As an aside: shouldn't
tumbeast.pngandbadcert.jpgbe removed? Fortumbeast.png, the related pageresources/not-found.htmldoesn't seem to be reachable by any means (the usual dry error message is used instead, as far as my testing goes, neitherabout:not-foundnorservo:not-foundwork), and the only use ofbadcert.jpg(inbadcert.html) got removed in 8422dac.Testing: Unnecessary. Since the optimized images haven't changed their extension, so long as Servo's PNG parsing is correct, there should be no change aside from reduced binary sizes.