servoshell: reduce duplication for conversion between physical/logical position/size#38082
Merged
jdm merged 1 commit intoservo:mainfrom Jul 15, 2025
Merged
servoshell: reduce duplication for conversion between physical/logical position/size#38082jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Euclid Ye <[email protected]>
yezhizhen
force-pushed
the
cleanup-conversion
branch
from
1885de5 to
b42e722
Compare
jdm
approved these changes
Jul 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
longvatrong111
added a commit
to longvatrong111/servo
that referenced
this pull request
Jul 15, 2025
…l position/size (servo#38082) (wd) {"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --product servodriver --headless", "number_of_wpt_chunks": 1}]}
longvatrong111
added a commit
to longvatrong111/servo
that referenced
this pull request
Jul 15, 2025
…l position/size (servo#38082) (wd) {"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --product servodriver --headless", "number_of_wpt_chunks": 1}]}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With helper functions introduced in #38020, this is now becoming reality.
Testing: No behaviour change.
Fixes: #37937