script: Get the screen metrics from the WebViewDelegate instead of via the compositor#38020
Merged
jdm merged 3 commits intoservo:mainfrom Jul 12, 2025
Merged
script: Get the screen metrics from the WebViewDelegate instead of via the compositor#38020jdm merged 3 commits intoservo:mainfrom
WebViewDelegate instead of via the compositor#38020jdm merged 3 commits intoservo:mainfrom
Conversation
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
jdm
approved these changes
Jul 12, 2025
Signed-off-by: Euclid Ye <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
…l position/size (#38082) With helper functions introduced in #38020, this is now becoming reality. Testing: No behaviour change. Fixes: #37937 Signed-off-by: Euclid Ye <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #37960, previously,
AvailHeight,AvailWidth,Height,Widthask compositor for screen metrics. This PR moves the request to embedder.This simplifies code, and reduces workload of compositor, which is busier most of time.
Testing: No behaviour change. Updated some tests.
Width/Heightmatches other browsers.