Rename original window_resizeTo.html to window_resize_event.html & Fix wrong usage of innerHeight & add new test#37856
Merged
jdm merged 1 commit intoservo:mainfrom Jul 4, 2025
Merged
Conversation
yezhizhen
changed the title
innerHeight in window_resizeTo.html & add new test
|
🔨 Triggering try run (#16055950363) for Linux (WPT) |
This was referenced Jul 3, 2025
|
Test results for linux-wpt from try job (#16055950363): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (1)
|
|
|
Signed-off-by: Euclid Ye <[email protected]>
Member
Author
|
Failure is because we renamed the original file, which very often fail to fire "onresize". I believe we need to rename the Intermittent issue #36741 right before adding this to MQ? |
yezhizhen
changed the title
innerHeight in window_resizeTo.html & add new testwindow_resizeTo.html to window_resize_event.html & Fix wrong usage of innerHeight & add new test
xiaochengh
reviewed
Jul 4, 2025
Contributor
There was a problem hiding this comment.
What's the purpose of this new test?
A test case for resizeTo without relying on the resize event? I'm not sure if we really need that.
Member
Author
There was a problem hiding this comment.
xiaochengh
approved these changes
Jul 4, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
…accurately (#37848) `toolbar_height` is already part of `inner_size`, caused wrongly calculated `outer_size`. Even worse, it tried to `request_inner_size` with the already wrong `outer_size`. This PR make sure resize is accurate by first calculate the title/border height, and then compute the `inner_size` for `request_inner_size`. This is necessary because no direct `request_outer_size` is available. Testing: As manually tested, set window size WebDriver command no longer overshoot. This is also shared by [window.resizeTo](https://drafts.csswg.org/cssom-view/#dom-window-resizeto) JS method. WPT test would be necessary. (But that one is intermittent TIMEOUT. So created new one in #37856) WebDriver test will be postponed after web-platform-tests/wpt#53421 is merged and synced to Servo. Fixes: Task 3 of #37804 --------- Signed-off-by: Euclid Ye <[email protected]>
Member
|
I've added the new test name to #36741 and we can update the title after it merges. That will avoid preventing other PRs from merging in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window_resizeTo.htmltowindow_resize_event.htmlto reflect the purpose. Also change {innerWidth, innerHeight} to {outerWidth, outerHeight} to match spec.window_resizeTo.htmlfor servoshell: Makefn request_resizeresize window w.r.t. outer_size accurately #37848Testing: new test always fails because of #37824, which gives inaccurate outerHeight.