Skip to content

Upgrade Stylo to 2025-07-01#37822

Merged
Loirooriol merged 2 commits intoservo:mainfrom
Loirooriol:stylo-2025-07-01
Jul 2, 2025
Merged

Upgrade Stylo to 2025-07-01#37822
Loirooriol merged 2 commits intoservo:mainfrom
Loirooriol:stylo-2025-07-01

Conversation

@Loirooriol
Copy link
Copy Markdown
Contributor

@Loirooriol Loirooriol commented Jul 2, 2025 •
edited
Loading

@Loirooriol Loirooriol added T-linux-wpt Do a try run of the WPT dependencies Pull requests that update a dependency file labels Jul 2, 2025
@github-actions github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jul 2, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2025

🔨 Triggering try run (#16013847646) for Linux (WPT)

@Loirooriol Loirooriol mentioned this pull request Jul 2, 2025
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2025

Test results for linux-wpt from try job (#16013847646):

Flaky unexpected result (10)
  • FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
  • OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
    • FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '400' over '350 399'

      assert_equals: Unexpected font on test element expected 487 but got 532

    • FAIL [expected PASS] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique 10deg' over 'oblique 0deg'

      assert_equals: Unexpected font on test element expected 487 but got 532

    • FAIL [expected PASS] subtest: Matching font-style: 'oblique -20deg' should prefer 'oblique 30deg 60deg' over 'oblique 40deg 50deg'

      assert_equals: Unexpected font on test element expected 487 but got 532

  • TIMEOUT [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/max-payload.tentative.https.window.html (#35210)
  • OK /html/browsers/browsing-the-web/navigating-across-documents/006.html (#21382)
    • PASS [expected FAIL] subtest: Link with onclick form submit and href navigation
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
    • PASS [expected FAIL] subtest: form submission
  • TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
  • TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
    • TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks

      Test timed out

  • OK /html/semantics/embedded-content/the-video-element/intrinsic_sizes.htm (#37173)
    • FAIL [expected PASS] subtest: default object size after src is removed

      assert_equals: expected "300px" but got "320px"

  • OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
    • PASS [expected FAIL] subtest: text/plain: Basic test (normal form)
  • TIMEOUT /preload/preload-resource-match.https.html
    • TIMEOUT [expected FAIL] subtest: Loading script (use-credentials) with link (no-cors) should discard the preloaded response

      Test timed out

    • NOTRUN [expected TIMEOUT] subtest: Loading script (use-credentials) with link (anonymous) should discard the preloaded response
Stable unexpected results that are known to be intermittent (23)
  • OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
    • FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed

      promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"

  • FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
  • TIMEOUT [expected OK] /_mozilla/mozilla/window_resizeTo.html (#36741)
    • TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo

      Test timed out

  • FAIL [expected PASS] /css/css-grid/grid-items/grid-auto-margin-and-replaced-item-001.html (#37162)
  • OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.tentative.https.window.html (#35176)
  • OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
    • PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
  • OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
    • PASS [expected FAIL] subtest: Link with onclick form submit to javascript url with document.write and href navigation
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
    • FAIL [expected PASS] subtest: Navigating to a different document with location.href

      assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"

    • FAIL [expected PASS] subtest: Navigating to a different document with location.assign

      assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"

  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
    • PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
    • PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
  • OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)
    • FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

      assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

  • OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])

  • TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
    • TIMEOUT [expected FAIL] subtest: Element with tabindex should support autofocus

      Test timed out

  • OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
  • TIMEOUT /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
    • NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • TIMEOUT /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
    • NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • OK /preload/preload-error.sub.html (#37177)
    • FAIL [expected PASS] subtest: success (style): main

      assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.css?label=style should be loaded expected a number greater than 0 but got 0

    • FAIL [expected PASS] subtest: 404 (style): main

      assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.css?pipe=status%28404%29&label=style should be loaded expected a number greater than 0 but got 0

    • PASS [expected FAIL] subtest: success (script): main
    • PASS [expected FAIL] subtest: 404 (script): main
    • FAIL [expected PASS] subtest: CORS (script): main

      assert_greater_than: http://not-web-platform.test:8000/preload/resources/dummy.js?pipe=header%28Access-Control-Allow-Origin%2C*%29&label=script should be loaded expected a number greater than 0 but got 0

    • PASS [expected FAIL] subtest: CORS (xhr): main
    • FAIL [expected PASS] subtest: Decode-error (style): main

      assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?pipe=header%28Content-Type%2Ctext%2Fcss%29&label=style should be loaded expected a number greater than 0 but got 0

  • CRASH [expected TIMEOUT] /resource-timing/tentative/document-initiated.html (#37785)
  • OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
  • OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
Stable unexpected results (1)
  • OK /css/css-color/parsing/color-valid.html
    • PASS [expected FAIL] subtest: e.style['color'] = "light-dark(black, white)" should set the property value

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2025

⚠️ Try run (#16013847646) failed.

@nicoburns nicoburns mentioned this pull request Jul 2, 2025
Open
@Loirooriol Loirooriol marked this pull request as ready for review July 2, 2025 11:10
@Loirooriol Loirooriol requested a review from mrobinson July 2, 2025 11:11
@Loirooriol
Copy link
Copy Markdown
Contributor Author

Loirooriol commented Jul 2, 2025

Is it fine to duplicate so many crates? Should I downgrade icu4x in Stylo instead?

@mrobinson
Copy link
Copy Markdown
Member

mrobinson commented Jul 2, 2025

I think we should avoid duplicating icu4x if possible based on #37823 (comment).

@nicoburns
Copy link
Copy Markdown
Contributor

nicoburns commented Jul 2, 2025

I've added more analysis to #37823

@nicoburns nicoburns mentioned this pull request Jul 2, 2025
Open
@Loirooriol
Copy link
Copy Markdown
Contributor Author

Loirooriol commented Jul 2, 2025

OK so I have downgraded icu in Stylo to keep 1.5, upgrading to 2.0 can then be coordinated in #37823

Loirooriol added 2 commits July 2, 2025 18:01
@Loirooriol
Upgrade Stylo to 2025-07-01
a8fe851 
Signed-off-by: Oriol Brufau <[email protected]>
@Loirooriol
Update test expectations
e85394d 
Signed-off-by: Oriol Brufau <[email protected]>
@Loirooriol Loirooriol enabled auto-merge July 2, 2025 16:02
@Loirooriol Loirooriol added this pull request to the merge queue Jul 2, 2025
Merged via the queue into servo:main with commit 26f5eb4 Jul 2, 2025
21 checks passed
@Loirooriol Loirooriol deleted the stylo-2025-07-01 branch July 2, 2025 17:08
@Loirooriol Loirooriol restored the stylo-2025-07-01 branch July 2, 2025 19:44
@Loirooriol Loirooriol deleted the stylo-2025-07-01 branch July 2, 2025 19:44
This was referenced Jul 12, 2025
Closed
Closed
@Loirooriol Loirooriol mentioned this pull request Aug 2, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 2, 2025
@Loirooriol
Upgrade Stylo to 2025-08-01 (#38429)
76e5758 
This continues #37822

Changelog:
- Upstream:
servo/stylo@fe9eadf...ec21cec
- Servo fixups:
servo/stylo@29052e5...7f8df16

Stylo tracking issue: servo/stylo#220

---------

Signed-off-by: Oriol Brufau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoburns nicoburns nicoburns approved these changes

@mrobinson mrobinson Awaiting requested review from mrobinson

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Loirooriol @mrobinson @nicoburns