Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
MichaelMcDonnell
force-pushed
the
fix-dbus-warning
branch
2 times, most recently
from
15a05ed to
4fbc3e8
Compare
I get the following warning message I run ./mach build: Could not generate notification: No module named 'dbus' I asked in the Zulip chat[1] if anyone was still using the feature and it sounds like most people do not use it anymore. It has been broken a while too and no one has stepped up to fix it. Gnome Terminal will automatically show a notification when a long running command is done. Some other terminals can also be configured to automatically show a notification when a long running command is done. I think it is safe to remove the feature. [1] https://servo.zulipchat.com/#narrow/channel/263398-general/topic/DBus.20warning.20when.20running.20.60.2E.2Fmach.20build.60 Testing: I manually tested it on Linux by running ./mach bootstrap followed by ./mach build Signed-off-by: Michael Mc Donnell <[email protected]>
MichaelMcDonnell
force-pushed
the
fix-dbus-warning
branch
from
4fbc3e8 to
43a70fb
Compare
Contributor
Author
|
Thanks for merging it! That warning has been bugging me for a while 😀 |
PotatoCP
added a commit
to PotatoCP/servo
that referenced
this pull request
Jul 3, 2025
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --pref=dom_testing_html_input_element_select_files_enabled --product servodriver --headless", "number_of_wpt_chunks": 1}]}
PotatoCP
added a commit
to PotatoCP/servo
that referenced
this pull request
Jul 3, 2025
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --pref=dom_testing_html_input_element_select_files_enabled --product servodriver --headless", "number_of_wpt_chunks": 1}]}
mrobinson
added a commit
to mrobinson/servo
that referenced
this pull request
Nov 18, 2025
Support for sending build notifications was removed in servo#37818, but the dependency in `requirements.txt` was not removed. This PR fixest that. Signed-off-by: Martin Robinson <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
Support for sending build notifications was removed in #37818, but the dependency in `requirements.txt` was not removed. This PR fixest that. Testing: This change just removes an unsued build dependency, so no testing is necessary. Signed-off-by: Martin Robinson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I get the following warning message I run ./mach build:
Could not generate notification: No module named 'dbus'I asked in the Zulip chat[1] if anyone was still using the feature and
it sounds like most people do not use it anymore. It has been broken a
while too and no one has stepped up to fix it.
Gnome Terminal will automatically show a notification when a long
running command is done. Some other terminals can also be configured to
automatically show a notification when a long running command is done.
I think it is safe to remove the feature.
[1] https://servo.zulipchat.com/#narrow/channel/263398-general/topic/DBus.20warning.20when.20running.20.60.2E.2Fmach.20build.60
Testing: I manually tested it on Linux by running ./mach bootstrap followed by ./mach build