script: Consolidate step 22 of per-Document rendering update#37703
Merged
mrobinson merged 1 commit intoservo:mainfrom Jun 26, 2025
Merged
Conversation
4 tasks
sagudev
approved these changes
Jun 25, 2025
Member
sagudev
left a comment
sagudev
left a comment
There was a problem hiding this comment.
I just hope this does not break any tests.
|
🔨 Triggering try run (#15883176237) for Linux (Production, WPT) |
The parts of step 22 were a bit scattered through the codebase, so this change moves them all to a single method which does three things: 1. Update all animating images 2. Flush all dirty canvases (2D, WebGL, and WebGPU) 3. Calls reflow on the `Document` Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
consolidate-document-update-the-rendering
branch
from
ba5c5c3 to
26d9fe9
Compare
|
Test results for linux-wpt from try job (#15883176237): Flaky unexpected result (12)
Stable unexpected results (4)
|
|
|
Member
|
This error is real: |
|
🔨 Triggering try run (#15887220040) for Linux (WPT) |
|
Test results for linux-wpt from try job (#15887220040): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (19)
|
|
✨ Try run (#15887220040) succeeded. |
sagudev
approved these changes
Jun 25, 2025
sagudev
added a commit
to sagudev/book-servo
that referenced
this pull request
Jun 26, 2025
Signed-off-by: sagudev <[email protected]>
This was referenced Jul 5, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 5, 2025
…ing long parsing (#37899) Before #37703 we were actually doing update rendering of canvases/images as part of `allow_layout_if_necessary` so let's keep doing that until we fix this properly as this will be much more involved and we want usable canvases in the mean time. Testing: Manual testing + WPT tests Fixes: #37891 --------- Signed-off-by: sagudev <[email protected]>
jdm
added a commit
to servo/book
that referenced
this pull request
Sep 5, 2025
* Write document about canvas (contexts) Signed-off-by: sagudev <[email protected]> * Apply some suggestions from code review Co-authored-by: shuppy <[email protected]> Signed-off-by: sagudev <[email protected]> * some manual applied review fixes Signed-off-by: sagudev <[email protected]> * Apply suggestions from code review Co-authored-by: Josh Matthews <[email protected]> Signed-off-by: sagudev <[email protected]> * more HTML event loop Signed-off-by: sagudev <[email protected]> * this is from codereview but somehow slipped from applying Signed-off-by: sagudev <[email protected]> * update after servo/servo#37703 Signed-off-by: sagudev <[email protected]> * compositor Signed-off-by: sagudev <[email protected]> * split seq diagrams Signed-off-by: sagudev <[email protected]> * Update src/architecture/canvas.md Signed-off-by: Josh Matthews <[email protected]> * Update src/architecture/canvas.md Signed-off-by: Josh Matthews <[email protected]> * Update src/architecture/canvas.md Signed-off-by: Josh Matthews <[email protected]> * Update src/architecture/canvas.md Signed-off-by: Josh Matthews <[email protected]> * Update src/architecture/canvas.md Signed-off-by: Josh Matthews <[email protected]> * Update src/architecture/canvas.md Signed-off-by: Josh Matthews <[email protected]> * Update src/architecture/canvas.md Signed-off-by: Josh Matthews <[email protected]> * Update src/architecture/canvas.md Signed-off-by: Josh Matthews <[email protected]> --------- Signed-off-by: sagudev <[email protected]> Signed-off-by: Josh Matthews <[email protected]> Co-authored-by: shuppy <[email protected]> Co-authored-by: Josh Matthews <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parts of step 22 were a bit scattered throughout the codebase, so this
change moves them all to a single method which does three things:
DocumentTesting: This shouldn't change behavior in any major way so it should
be covered by existing WPT tests.