Skip to content

webdriver: Move navigation commands to servoshell#37665

Merged
mrobinson merged 1 commit intoservo:mainfrom
longvatrong111:webdriver-navigation
Jun 25, 2025
Merged

webdriver: Move navigation commands to servoshell#37665
mrobinson merged 1 commit intoservo:mainfrom
longvatrong111:webdriver-navigation

Conversation

@longvatrong111
Copy link
Copy Markdown
Contributor

@longvatrong111 longvatrong111 commented Jun 24, 2025

  • Move webdriver GetViewportSize, LoadURL and Refresh to servoshell.
  • Add GoBack and GoFoward commands.

Testing: Need to finish moving webdriver to servoshell then evaluate again
Fixes: #37370

@longvatrong111 longvatrong111 marked this pull request as ready for review June 25, 2025 09:12
@longvatrong111 longvatrong111 changed the title Move webdriver navigation commands to servoshell webdriver: Move navigation commands to servoshell Jun 25, 2025
@longvatrong111
Copy link
Copy Markdown
Contributor Author

longvatrong111 commented Jun 25, 2025

Hi @mrobinson , do you want to have a look at this? Thank you.
This PR is the follow up, you can check it if you don't mind a bigger change.

Copy link
Copy Markdown
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks!

@mrobinson mrobinson added this pull request to the merge queue Jun 25, 2025
Merged via the queue into servo:main with commit 62a0093 Jun 25, 2025
21 checks passed
@longvatrong111 longvatrong111 deleted the webdriver-navigation branch June 25, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[webdriver] Moving webdriver to servoshell

3 participants