script: Remove redundant vector allocation in Node::insert while inserting single node#37583
Open
MegaCorn wants to merge 1 commit intoservo:mainfrom
Open
script: Remove redundant vector allocation in Node::insert while inserting single node#37583MegaCorn wants to merge 1 commit intoservo:mainfrom
Node::insert while inserting single node#37583MegaCorn wants to merge 1 commit intoservo:mainfrom
Conversation
mrobinson
changed the title
Node::insert while inserting single node
mrobinson
requested changes
Jun 20, 2025
Signed-off-by: MegaCorn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: It is difficult to quantify the benefits due to volatility. Use the flame graph to see if there is any vector allocation
Fixes: #37223